Skip to content

Conversation

@itsjeyd
Copy link
Member

@itsjeyd itsjeyd commented Mar 8, 2016

cf. MCKIN-3884

Test instructions

  1. Add Problem Builder block to a unit.
  2. Add MCQ block to Problem Builder block.
  3. Add a couple of Choice blocks to MCQ block.
  4. For each choice, add a Tip block with a unique message.
  5. Publish.
  6. In LMS/Apros, answer question, click "Submit". Once tip for selected choice is visible, click somewhere else to make tip disappear.
  7. Click result icon next to selected choice. Observe that tip becomes visible again.

@jbzdak
Copy link
Contributor

jbzdak commented Mar 8, 2016

👍

("feedback_persistence_mcq_no_tips.xml", '.feedback')
)
def test_feedback_persistence_tips(self, scenario, tips_selector):
# Tests whether feedback is hidden on reload.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a problem with docstrings on ddt methods. Basically it makes things more complicated.

Reruning only some subsets of tests really hard. DDT generates long method names (like this one: test_feedback_persistence_tips__O_feedback_persistence_mcq_no_tips_xml__feedback_ --- this is not precise name but close). When this method has a docstring noseruner displays the docstring instead of method name. So I can't just copy that name for debugging purposes.

Moreover in test logs you'll see couple of tests labeled: "Tests whether feedback (global message and choice tips) is hidden on reload." and only one of them can fail :)

Long term I'd invest some time on tweaking runner to display method names always, but for now I'd lean towards avoiding docstrings for ddt tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbzdak

... for now I'd lean towards avoiding docstrings for ddt tests.

With you on that. Reverted to an in-line comment.

itsjeyd added a commit that referenced this pull request Mar 8, 2016
Restore functionality for showing choice tips on click
@itsjeyd itsjeyd merged commit 594f1f2 into master Mar 8, 2016
@bradenmacdonald bradenmacdonald deleted the fix-choice-tips branch March 11, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants