Fix mako template context error #117
Conversation
| """ Render this XBlock within a mentoring block. """ | ||
| context = context or {} | ||
| context = context.copy() if context else {} | ||
| context['self'] = self |
There was a problem hiding this comment.
I trust you that this fixes the issue, but I'm confused by why having "self" as a parameter in context doesn't mess up mako's render function
There was a problem hiding this comment.
This XBlock uses Django to render its templates, not mako. The problem only occurs if this block unintentionally modifies the context dict that was passed as an argument, so that the 'self' gets added to a different scope/context entirely (e.g. it gets added to the context of the parent block).
There was a problem hiding this comment.
Example:
>>> from django.template import Context, Template
>>> Template(u"hello").render(Context({'self': 'present'}))
u'hello'
|
@bradenmacdonald 👍 Verified that with this change pulled in, the |
This fixes https://openedx.atlassian.net/browse/TNL-4901 by backporting the already-existing fix that was on the
masterbranch.The problem was that
mentoring_viewwas inadvertently modifying itscontextparameter.Note 1: @adampalay tested and confirmed this fixes the TNL-4901 issue.
Note 2: on this branch, CircleCI is expected to fail (it's only configured on master), but TravisCI is required to pass - so the tests are fine.