Update xblock-utils to v1.0.3. #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version includes fixes from openedx-unsupported/xblock-utils#38 and openedx-unsupported/xblock-utils#39.
XBlock is listed as a dependency in requirements files for xblock-sdk, xblock-utils, and problem-builder itself. These files list different (but compatible) versions of the XBlock repo. Because of that, XBlock gets installed multiple times when installing dependencies for CircleCI builds. Starting with setuptools 25.0.0, the behavior for installing packages on top of existing installs changed; see pypa/setuptools#729 for an example issue that this change in behavior caused. For problem-builder CI builds, the issue was that after installing all dependencies, the egg link for XBlock ended up pointing to the installation of problem-builder itself, creating a situation where the code that ships with XBlock was not accessible from modules that depend on it. This caused imports for any classes defined in the XBlock repo to fail, and CircleCI builds errored out. To fix this, we temporarily pin setuptools to the most recent version that does not exhibit this behavior (24.3.1). An upstream fix seems to be underway (via pypa/pip#3904), but it hasn't been merged/released yet.
itsjeyd
force-pushed
the
update-xblock-utils
branch
from
5955397 to
51277a3
Compare
| override: | ||
| - "pip install -U pip wheel setuptools" | ||
| - "pip install -U pip wheel" | ||
| - "pip install setuptools==24.3.1" |
Member
There was a problem hiding this comment.
Nit: yml files support comments; can you please add a link here to 51277a3 in case people are wondering why this is pinned and don't do a git blame?
Member
|
Hmm, that setuptools bug looks annoying. Thanks for these fixes, Tim. 👍 if you add the requested comment.
You can then feel free to merge. |
setuptools to a specific version for now.
Member
Author
|
Thanks @bradenmacdonald! I addressed your nit. Merging now. |
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version includes fixes from openedx-unsupported/xblock-utils#38 and openedx-unsupported/xblock-utils#39.
Follow-up PR for OC-1819 (candidate task).
Also fixes an issue affecting dependency installation for CircleCI builds for problem-builder. See the commit message of 51277a3 for details.