MCKIN-11065 Fixed empty popups appearing for tips #242
Conversation
|
Hi @xitij2000 , can you please review this PR? Actually, the team doesn't have any access for the xblock to review this PR. Thanks |
setup.py
Outdated
| # Constants ######################################################### | ||
|
|
||
| VERSION = '3.3.9' | ||
| VERSION = '3.4.0' |
There was a problem hiding this comment.
This can just be a patch bump to 3.3.10
|
@mudassir-hafeez Sure. I have scheduled this PR for review next sprint. Till then, could you update the ticket description to include more details, and add testing instructions? |
|
@xitij2000, I have updated the test cases and description accordingly. Ping me if you need to update anything else 🙂 |
|
Hey @mudassir-hafeez, sorry for the delay, I didn't subscribe to this PR. I'll review it by tomorrow. |
|
@Agrendalath thanks for taking this PR to review. I have updated the version 3.3.10 to 3.3.11 as |
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
Thank you for fixing this, @mudassir-hafeez. Looks good to me.
👍
- I tested this: created MRQ block on local devstack and checked that popups no longer appear after (un)checking answer
- I read through the code
-
I checked for accessibility issues -
Includes documentation
|
Thanks, @Agrendalath. 🙂 |
|
@mudassir-hafeez, it's already here :) |
Oh great. Thanks, @Agrendalath. |
3 participants
After the first attempt of submitting MRQ feedback, when a user clicks on any item feedback icon, a popup appears with a choice tip. while in the second attempt of resubmitting MRQ feedback, when a user clicks on any item feedback icon after clicking on any choice and before submitting MRQ then a popup appears with an empty choice tip messages.
Please see the picture below for better understanding:
After this fix, the user will not see the container containing an empty choice tip.