Skip to content

Conversation

@moeez96
Copy link
Contributor

@moeez96 moeez96 commented Sep 30, 2019

MCKIN-11571

Change ja translation for the Submit button as mentioned in the ticket.
Translations were not pushed to tranisfex.

@moeez96
Copy link
Contributor Author

moeez96 commented Sep 30, 2019

@xitij2000 Please review.
If approved, please merge and create a release version too.

@msaqib52
Copy link
Contributor

@moeez96 have approved the PR, don't forget to bump the version before the merge.

@moeez96
Copy link
Contributor Author

moeez96 commented Sep 30, 2019

@msaqib52 Thank you. I dont have access to merge or create a release version.

Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • [na] I tested this: trivial change
  • I read through the code
  • [na] I checked for accessibility issues
  • [na] Includes documentation

setup.py Outdated
# Constants #########################################################

VERSION = '3.3.9'
VERSION = '3.4.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the patch version since this is a minor change. So 3.3.10

@moeez96
Copy link
Contributor Author

moeez96 commented Sep 30, 2019

@xitij2000 updated patch version. Please review again.
If accepted, please merge and create a release tag which can be added to edx-platform.

@xitij2000 xitij2000 merged commit a28e1cc into open-craft:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants