-
Notifications
You must be signed in to change notification settings - Fork 60
MCKIN-12152 AF#40-MRQ-Inform assistive technologies of changes in content #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@xitij2000 Please review. |
|
@nasirhjafri I've added this to the review backlog, but unfortunately we will probably only be able to get to it next sprint since it wasn't included in the original PR list sent last sprint. |
|
@nasirhjafri, please rebase it on the |
803546a to
0835052
Compare
|
@Agrendalath Rebased with the master. |
|
@nasirhjafri, @Agrendalath, I will review the changes today and post my feedback after that. FYI. |
|
@nasirhjafri, I tried testing the changes in this PR on the Ironwood devstack. However, I cannot trigger the expected behaviour at all and the element containing the |
|
@nasirhjafri, I tested the changes on the custom LMS frontend opened in the Microsoft Edge browser, using the NVDA screen reader on Windows 10 and verified that it works as described. However, when using the built-in screen reader on Windows 10, it didn't work the same way. Since all the screen reader software use the same HTML elements and attributes, I am not sure how and why this happens. If you have any idea about this, please let me know. Otherwise, this PR looks good to be merged. I will approve after checking your response. |
|
@lgp171188 I don't have an idea about Windows 10 screen reader. We can merge this one as the recommended screen reader is NVDA. |
|
@nasirhjafri, no problem. I will squash and merge the changes after the CI checks pass and then tag a release and ping you. |
lgp171188
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this with the NVDA screen reader and verified that it works as expected.
- I read through the code
- I checked for accessibility issues
-
Includes documentationNA
MCKIN-12152 AF#40-MRQ-Inform assistive technologies of changes in content
[Issue]
When the submit button is activated, there is new content added to the page without notifying the user through an announcement. Feedback text appears after the submit button.
[Resolution]
Upon activating the "Submit" button, additional content gets added beneath this button that provides feedback on the response submitted. Upon activating this button, please ensure to set focus to this newly added textual content using the JavaScript focus method, so that assistive technologies such as screen readers would be aware of this content update and would render this content to the screen reader users. Also, place a tabindex of -1 on this dynamically added feedback content container, so that it doesn't appear in the tab order.