[BB-2320] Added the MySQL Readme for Problem builder #282
Conversation
xitij2000
left a comment
xitij2000
left a comment
There was a problem hiding this comment.
I think the readme doesn't work as of yet. I faced a number of failures:
- The xblock-sdk's
make installcommand files. The incorrect version is used here, it should be 0.1.8 instead of 0.1.7 - The migration command failed since the current readme asks you to override
DATABASES['default']['NAME'] = 'var/workbench.db'
rusrushal13
force-pushed
the
rushal/BB-2230-MySQL-README
branch
from
dfda39a to
724801e
Compare
@xitij2000 Thanks for the review, I had some issues, which @lgp171188 helped me to resolve it; Now I have tested it on an Ubuntu 16.04(Xenial64) VM with python 3.5.2 installed and it works there fine. Let me know if you face any issues :) |
README.md
Outdated
| By default, the `xblock-sdk` uses the SQLite database but MySQL | ||
| can be used by specifying an environment variable `WORKBENCH_DATABASES` in | ||
| the following format. | ||
|
|
||
| ```bash | ||
| export WORKBENCH_DATABASES='{"default": {"ENGINE": "django.db.backends.mysql", "NAME": "db", "USER": "root", "PASSWORD": "rootpw", "HOST": "127.0.0.1", "PORT": "3306"}}' | ||
| ``` |
There was a problem hiding this comment.
@rusrushal13, I think this paragraph, can be moved to after the docker run command. What do you say?
There was a problem hiding this comment.
First I thought the same, but running the export command before running the database looks better to me, that's why I have kept it before the docker command. What do you think?
xitij2000
left a comment
xitij2000
left a comment
There was a problem hiding this comment.
👍 The changes look good. Could you also update xblock-sdk submodule here to the same version as that in the requirements file, and fix the port in the readme? Other than that it is good to go.
- I tested this: tested setting up based on readme
- I read through the code
- Includes documentation
…ushal/BB-2230-MySQL-README
[BB-2320] Added the MySQL Readme for Problem builder (open-craft#282)
Issue: BB-2320
Testing Instructions:
Reviewers: