MCKIN-24633 translation issue for portuguese #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committer: Mudassir Hafeez <mudasir5761@gmail.com>
mudassir-hafeez
force-pushed
the
MCKIN-24633-v3
branch
from
01d1822 to
1546830
Compare
Contributor
Author
|
@xitij2000 failed test does not seem to be related to this PR. Can you please have a look? |
|
@mudassir-hafeez, Thanks for the PR. Re-running circle-ci jobs seem to pass this time. |
Contributor
Author
shimulch
approved these changes
Sep 22, 2020
shimulch
left a comment
shimulch
left a comment
There was a problem hiding this comment.
LGTM 👍
- I tested this: ran tests locally
- I read through the code
- [ ] I checked for accessibility issues
- [ ] Includes documentation
- [ ] I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
|
Released v3.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we load the instructor tool for portuguese, the following error message shows:
Actually,
segundosreference is not define and seems like a translation in Portuguese which was used mistakenly. so updating it into an accurate reference.