Fix JS bug when HTML block is followed by an answer block #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelketek
changed the title
Member
|
👍 |
bradenmacdonald
added a commit
that referenced
this pull request
Jul 22, 2015
Fix JS bug when HTML block is followed by an answer block
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a JS error that would occur when a PB block contains an HTML child followed by an answer block:
TypeError: Cannot read property 'toString' of undefinedThe reason for the error is that HTML blocks don't have a
nameproperty. This fix is simple. Unfortunately I couldn't figure out how to add a regression test for this, since the workbench runtime doesn't appear to have this bug - only the edx-platform runtime.Sandbox URL that previously had the issue: http://sandbox2.opencraft.com/courses/course-v1:HGSE+1x+2015/courseware/Week_1_Welcome_and_orientation/Change_Diary_Using_the_Change_Diary/