Skip to content

Conversation

@itsjeyd
Copy link
Member

@itsjeyd itsjeyd commented Aug 19, 2015

This PR extends existing functionality of the instructor tool by allowing users to enter multiple usernames to search for answers from multiple users simultaneously.

The input field for entering usernames expects usernames to be separated by commas, but is not sensitive to whitespace (meaning that commas can be surrounded by arbitrary amounts of whitespace).

Testing

From Studio:

  1. Add pb-instructor-tool to advanced modules.
  2. Add one or more MCQs/rating questions/long answer blocks to a unit.
  3. Add an instructor tool block to the same or another unit.

From the LMS:

  1. Sign in as staff and provide answers to some of the MCQ/rating questions/long answers blocks.
  2. Repeat previous step for honor, audit, etc.
  3. Sign in as staff and switch to instructor tool. Enter usernames of one or more users and click "Search". Observe that results include answers provided by users specified in the input field.
  4. Repeat previous step for other combinations of usernames.

@itsjeyd itsjeyd force-pushed the instructor-tool-multiple-usernames branch from f3c9504 to d610839 Compare August 20, 2015 17:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need re.split here - can't you just use usernames.split(',') ?

@bradenmacdonald
Copy link
Member

Left a few minor comments but otherwise this looks good 👍

@itsjeyd itsjeyd force-pushed the instructor-tool-multiple-usernames branch from d610839 to 7460c77 Compare August 21, 2015 06:41
@itsjeyd
Copy link
Member Author

itsjeyd commented Aug 21, 2015

@bradenmacdonald Thanks! Comments addressed.

itsjeyd added a commit that referenced this pull request Aug 24, 2015
…ames

Instructor Tool: Support searching for answers from multiple users
@itsjeyd itsjeyd merged commit cd2304e into master Aug 24, 2015
@xitij2000 xitij2000 deleted the instructor-tool-multiple-usernames branch December 13, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants