-
Notifications
You must be signed in to change notification settings - Fork 60
Step navigation and submission for new mentoring block #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
navigating to next step.
of current step (and its children).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjeyd Is there any particular benefit of not using Dict field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-kolpakov Hm. Maybe for the odd case where a question (with a non-unique name) is used multiple times within the same step? With a List field we'd be able to retain results for all occurrences of the question in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjeyd this is unlikely to work at all - how do you than distinguish the questions when you need to display their values? By sequential number? I'm not sure it would work (but not sure it wouldn't as well). Let's keep it as is for now, but please keep in mind it might make sense to use Dict.
|
@itsjeyd there's one minor issue in studio editing - not sure if it slipped from the previous task or was added as part of this one: "Que?" there is a "Question" field of an MCQ - looks like student view is reused for preview view. If it's not clear, the screehnshot is made when editing MCQ answers. |
|
@e-kolpakov Thanks for the comments. I looked into the studio editing issue -- it's present in the existing mentoring block as well and it seems like it's caused by a peculiarity of def get_author_edit_view_fragment(self, context):
"""
The options for the 1-5 values of the Likert scale aren't child blocks but we want to
show them in the author edit view, for clarity.
"""
fragment = Fragment(u"<p>{}</p>".format(self.question))
self.render_children(context, fragment, can_reorder=True, can_add=False)
return fragmentThis behavior was introduced way back in Feb -- let me know if you think I should still change it as part of this PR. |
|
@itsjeyd if it's an existing behavior - let's just keep it. I just haven't saw it before for some reason, so I thought it was a regression |
|
@itsjeyd 👍 |
Step navigation and submission for new mentoring block

This PR adds step navigation and submission functionality to the new blocks introduced in #62.
Screenshots
New mentoring block displaying a single step (with multiple questions):
After submitting the current step (all answers correct):
After submitting the current step (some answers correct):
After submitting the current step (no correct answers):