Skip to content

Step Builder: Review step and assessment functionality #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjeyd merged 43 commits into from
Sep 29, 2015
Merged

Step Builder: Review step and assessment functionality #65

itsjeyd merged 43 commits into from
Sep 29, 2015

Conversation

@itsjeyd
Copy link
Member

@itsjeyd itsjeyd commented Sep 28, 2015

This PR introduces a ReviewStep block and adds assessment functionality to the new mentoring block (Step Builder).

Testing

  1. Enable Step Builder by adding step-builder to the list of advanced modules in Studio.
  2. Create a new unit and add a Step Builder block.
  3. Add a few Mentoring Step blocks to the Step Builder block.
  4. Add a Review Step block to the Step Builder block. Note that you can only add a single Review Step block (after adding it the corresponding button becomes disabled).
  5. Add some questions to each step.
  6. Test functionality by completing the questions you added in the LMS, trying different settings for max_attempts and extended_feedback.

@itsjeyd
Rename: pb-mentoring -> step-builder; pb-mentoring-step -> sb-step.
2d9110d
@itsjeyd
Introduce ReviewStep block and allow adding it to new mentoring
7a5e230 
block (step builder).
@itsjeyd
Hide review step by default.
8b4df83
@itsjeyd
Add "Review grade" button and hide/show/enable/disable it when approp…
987e583 
…riate.
@itsjeyd
Show review step when clicking on "Review grade" button.
defaff3
@itsjeyd
Allow only one review step per mentoring block.
433ce15
@itsjeyd
Redirect to review step when reloading page after submitting last step.
f07502f
@itsjeyd
Hide "Submit", "Next Step", "Review grade" buttons when displaying
1806c75 
review step.
@itsjeyd
Don't show "Try again" button at last step.
d91007a
@itsjeyd
Handle cases where review step is not present (because it has not been
431bc48 
added to current mentoring block).
@itsjeyd
Show appropriate assessment message when reaching review step.
a06370c
@itsjeyd
Add max_attempts and num_attempts fields to new mentoring block and make
839840a 
max_attempts editable in Studio.
@itsjeyd
Update num_attempts field of new mentoring block after submitting las…
677ffef 
…t step.
@itsjeyd
Add implementation for max_attempts_reached property (was just returning
177e01e 
False until now).
@itsjeyd
Show info about number of attempts used if limited number of attempts…
c251a61 
… available.
@itsjeyd
Disable "Try again" button if no attempts left.
6a86b67
@itsjeyd
Make sure "Review grade" button is disabled at last step.
8f86a2e
@itsjeyd
Don't show "Try again" button if no review step present; show message
95c9486 
about number of submissions used instead.
@itsjeyd
Don't allow num_attempts to be larger than max_attempts.
ca1e9f9
@itsjeyd
Display score (percentage) and count of correct/partial/incorrect ans…
bc87907 
…wers.
@itsjeyd
Introduce extended_feedback field and make it editable in Studio.
fce6efc
@itsjeyd
Change default display names of existing mentoring block ("Problem
a69d486 
Builder") and new mentoring block ("Step Builder").
@itsjeyd
Show review tips if there are some attempts left.
ef0812a
@itsjeyd
Get rid of "runDetails not defined error".
9e86458
@itsjeyd
Add functionality for reviewing steps.
67a9c25
@itsjeyd
Display step- and answer-level feedback when reviewing step.
0d62734
@itsjeyd
Conditionally enable "Try again" button when showing review step.
a0dfa54
@itsjeyd
Make sure relevant info is updated and retrieved sequentially after
c3a7d6d 
submitting step.
@itsjeyd
Fix: Make sure links for reviewing questions are not displayed multiple
9c847f2 
times at review step.
@itsjeyd
Clean up.
026446e 
- Improve naming of functions that handle submission results
- Add comments
- Remove empty leftover comments
- DRY out code that handles showing step-level feedback
- Don't name things using snake_case in JS code
- Use "callIfExists" in more places
@itsjeyd itsjeyd force-pushed the review-step branch 5 times, most recently from 5decd96 to c92b9fe Compare September 28, 2015 10:17
mtyaka
mtyaka reviewed Sep 28, 2015
View reviewed changes
problem_builder/mentoring.py Outdated
Copy link
Member

@mtyaka mtyaka Sep 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsjeyd It is not obvious how questions differs from get_questions only by looking at the method names. Maybe rename questions to question_ids and get_questions to questions?

@itsjeyd itsjeyd force-pushed the review-step branch 3 times, most recently from e20f8e2 to 47fe2f6 Compare September 29, 2015 06:58
@itsjeyd
Make sure num_attempts info is always up-to-date by fetching it from
1ff860a 
server when initializing Step Builder XBlock on the client.
@mtyaka
Copy link
Member

mtyaka commented Sep 29, 2015

👍

itsjeyd added a commit that referenced this pull request Sep 29, 2015
@itsjeyd
Merge pull request #65 from open-craft/review-step
dde3c4c 
Step Builder: Review step and assessment functionality
@itsjeyd itsjeyd merged commit dde3c4c into master Sep 29, 2015
@itsjeyd itsjeyd mentioned this pull request Aug 9, 2016
Merged
3 tasks
@xitij2000 xitij2000 deleted the review-step branch December 13, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsjeyd @mtyaka