Problem Builder: Fix submission of incorrect questions without review tips #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following regression:
If the last question belonging to a mentoring block is an MCQ/MRQ and has no "Assessment Review" message component, it can't be submitted. The error happens only when trying to submit a wrong answer.
Testing
Add Problem Builder block to unit.
Temporarily enable mode switching by adding
modetoeditable_fields(mentoring.py, line 321):This is necessary because mode switching was disabled in Step Builder: Add mentoring-level messages to review step and disable mode switching for Problem Builder #66 (as a first step towards deprecating assessment functionality of Problem Builder), and the bug only affects assessment mode.
Set mode to "assessment".
Add an MCQ, a Rating, and an MRQ to the block.
Complete block in the LMS, submitting an incorrect answer for each question. Observe that it is possible to submit answers and get to the next step without having to reload the page.
Verify that there are no
TypeErrors in the server logs.