Skip to content

Enable seamless use of steps that have no questions. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kelketek merged 1 commit into from
Oct 19, 2015
Merged

Enable seamless use of steps that have no questions. #76

Kelketek merged 1 commit into from
Oct 19, 2015

Conversation

@Kelketek
Copy link
Member

@Kelketek Kelketek commented Oct 15, 2015

To test:

  1. Add 'step-builder' to advanced modules.
  2. Create a step builder block.
  3. Create a few steps within the step builder block.
  4. Fill some with nothing but fluff, others with questions
  5. Make sure you can move through the fluff steps without disrupting functionality of the questions
  6. Make sure the button semantics make sense-- next or review where appropriate

@e-kolpakov

e-kolpakov
e-kolpakov reviewed Oct 16, 2015
View reviewed changes
problem_builder/public/js/mentoring_with_steps.js
Copy link
Contributor

@e-kolpakov e-kolpakov Oct 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelketek these two new blocks are almost identical - would be good to refactor them into method.

@Kelketek
Copy link
Member Author

Kelketek commented Oct 16, 2015

@e-kolpakov Addressed notes, fixed quality issue. Could you take a further look?

@e-kolpakov
Copy link
Contributor

e-kolpakov commented Oct 19, 2015

@Kelketek 👍

Kelketek added a commit that referenced this pull request Oct 19, 2015
@Kelketek
Merge pull request #76 from open-craft/empty_step
2105c1b 
Enable seamless use of steps that have no questions.
@Kelketek Kelketek merged commit 2105c1b into master Oct 19, 2015
@Kelketek Kelketek deleted the empty_step branch October 19, 2015 14:32
bradenmacdonald added a commit that referenced this pull request Oct 21, 2015
@bradenmacdonald
Fix to be compatible with PR #76
2f7e35a
@itsjeyd itsjeyd mentioned this pull request Aug 9, 2016
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kelketek @e-kolpakov