-
Notifications
You must be signed in to change notification settings - Fork 60
Fix invalid appearance in Apros due to their box-sizing global #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bradenmacdonald 👍 - not verified for the same reason I gave at jquery-xblock PR |
|
@bradenmacdonald Thanks for fixing this! The screenshots made me notice that the checkmarks/exclamation marks aren't well aligned - if you look closely their center is below the center of the corresponding line. (It's also worth checking with answers that have multiple lines btw, or contain HTML, as we've had issues with those in the past) |
|
@bradenmacdonald I would have given you a +1, but since @antoviaque appears to have added a bit here, so I'm going to hold off until that's all groovy. |
a721121 to
08cad15
Compare
|
@bradenmacdonald That looks great : ) Thanks for the fix! |
|
@bradenmacdonald I'm going to work on getting a rebased solutions devstack up and running. However I'd like you to see if you can fix the flaky test that failed the push build on Travis in the meantime. |
|
@Kelketek Sure thing. I have now fixed the flaky test in this PR (I hope). Turns out I was using a random number that was not sufficiently random, resulting in conflicting ids for label/checkbox pairs. |
|
@bradenmacdonald verified, this PR looks good, but it missed the fixes you made in #9. Conditional 👍 if #9 is to be added later. |
|
Thanks @e-kolpakov. Yes, Once #9 is approved and merged I will cherry-pick all of its fixes onto master as well. |
|
LGTM 👍 |
Fix invalid appearance in Apros due to their box-sizing global


Apros CSS has the rule
*, *:before, *:after { box-sizing: border-box; }, which (not surprisingly) messes up the layout of our tip popups.Before screenshot:

After screenshot:

Testing instructions:
Use a birch rebase branch of the solutions fork of edx-platform. The only one that's currently working for me is braden/birch-rebase-testing
Add the following to
~/lms.env.json:Open Apros and look at an MCQ/MRQ with tips.