Fix exponential rerendering after hitting next button too many times. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would be helpful if you included a course export to replicate the issue - it would reduce the review time significantly. |
bradenmacdonald
added a commit
that referenced
this pull request
Feb 22, 2016
Fix exponential rerendering after hitting next button too many times.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After each tap of the 'next' button, the updateDisplay function would be called and apply itself to the next button again, causing exponential rendering runs which would freeze things up after a certain number of questions.
@e-kolpakov This one's a critical hotfix. Please look at it first opportunity, if you can, so we can deploy it Monday.