Open
Conversation
Filenames are based on DWARF info from the `.nss` inside Bloons TD5's romFS
Only defined member variables and virtual functions, not general functions
`detail::SoundArchiveFileReader` required definitions from other files, which were added as needed
Some methods have been left as comments because of undeclared classes needed for them
An extra header for `nn::audio` was added as it was used in `atk_Adpcm.h`
Also include all `nn::audio` headers in audio.h
Defined more methods that were missing, static variables and fixed some signatures. Also added macro checks for the nnSdk version for files that might need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of all headers, types, typedef, etc. I could find based on DWARF info. Filenames, member names and enums are taken straight from the DWARF, file structure comes from information derived from strings, class names and function names are a combination of DWARF and crossreferencing symbols of other executables, and most function parameter names come from the DWARF, with a few being guesswork based on surrounding names. Changes to
util_IntrusiveList.hwere made while I was working on this, so I included those changes as well as my own for some classes that needed it (namelynn::atk::detail::fnd::HeapBaseneedingutil::IntrusiveListBaseNodeTraits). Aside from that, I also added files fornn::audioasnn::atkuses them in various places, as well asnn/os/os_MessageQueue.hpurely for the definition of nn::os::MessageQueue.I'd like to point out that I was working with a DWARF for version 5.3.0, and while I tried to account for changes between versions, there may still be some that I missed. I'm confident though that no major changes to structs at least happened to atk between 4.x.x and 5.3.0, but some structs are changed or missing for versions below that.
This change is