Skip to content

chore: integration tests#312

Merged
skyerus merged 8 commits intoopen-feature:mainfrom
skyerus:issue-176_integration-test-suite
Feb 22, 2023
Merged

chore: integration tests#312
skyerus merged 8 commits intoopen-feature:mainfrom
skyerus:issue-176_integration-test-suite

Conversation

@skyerus
Copy link
Copy Markdown
Contributor

@skyerus skyerus commented Jan 24, 2023

Signed-off-by: Skye Gill gill.skye95@gmail.com

This PR

  • Implements integration tests
  • Runs integration tests against built flagd image in CI

Related Issues

Fixes #176

Notes

Follow-up Tasks

How to test

skyerus
skyerus commented Jan 24, 2023
View reviewed changes
Comment thread go.mod Outdated
skyerus
skyerus commented Jan 24, 2023
View reviewed changes
Comment thread tests/integration/README.md Outdated
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 4a8823d to c62cab2 Compare January 26, 2023 11:41
@skyerus skyerus marked this pull request as ready for review January 26, 2023 12:23
@toddbaert
Copy link
Copy Markdown
Member

toddbaert commented Jan 26, 2023

@skyerus as discussed, these snyk failures are probably related to the stale go mod files in contribs... Let's update those and see if this is resolved.

@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 5a6c016 to 0f15b9d Compare January 27, 2023 11:09
@skyerus
Copy link
Copy Markdown
Contributor Author

skyerus commented Jan 27, 2023

@skyerus as discussed, these snyk failures are probably related to the stale go mod files in contribs... Let's update those and see if this is resolved.

Baffled :(

@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from d2d4759 to 49d814b Compare January 30, 2023 12:29
This was referenced Jan 30, 2023
Merged
Merged
@toddbaert
Copy link
Copy Markdown
Member

toddbaert commented Jan 30, 2023

Let me take care of getting this one merged.

@toddbaert toddbaert self-assigned this Jan 30, 2023
@toddbaert toddbaert force-pushed the issue-176_integration-test-suite branch from 49d814b to 598bcff Compare January 31, 2023 22:44
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 598bcff to 0456e46 Compare February 1, 2023 14:36
toddbaert
toddbaert reviewed Feb 1, 2023
View reviewed changes
Comment thread go.mod Outdated
toddbaert
toddbaert reviewed Feb 1, 2023
View reviewed changes
Comment thread go.mod Outdated
toddbaert
toddbaert reviewed Feb 1, 2023
View reviewed changes
Comment thread go.mod
@toddbaert toddbaert force-pushed the issue-176_integration-test-suite branch from 1611213 to 0456e46 Compare February 1, 2023 17:22
@toddbaert
Copy link
Copy Markdown
Member

toddbaert commented Feb 1, 2023 •
edited
Loading

@skyerus I'm hoping the v2 go-sdk update might resolve this odd Snyk issue.

The only thing I'm able to confirm is that the vuln is coming through transitively through the go-sdk.

toddbaert
toddbaert reviewed Feb 2, 2023
View reviewed changes
Comment thread go.mod
@toddbaert toddbaert force-pushed the issue-176_integration-test-suite branch 2 times, most recently from 6107830 to 48af239 Compare February 2, 2023 20:24
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 48af239 to 48fdd38 Compare February 3, 2023 15:02
toddbaert
toddbaert reviewed Feb 3, 2023
View reviewed changes
Comment thread go.mod Outdated
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 6d93b5e to 734692e Compare February 6, 2023 12:05
@skyerus skyerus mentioned this pull request Feb 6, 2023
Merged
@skyerus
Copy link
Copy Markdown
Contributor Author

skyerus commented Feb 6, 2023

Tests will fail until #375 is merged

skyerus added a commit that referenced this pull request Feb 6, 2023
@skyerus
fix: set ResolveObject reason (#375)
dcf199d 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- Reinstate setting of ResolveObject's reason

Discovered as [integration tests
PR](#312) started failing. In
future this kind of thing will be picked up as a pipeline failure (all
the more reason to get to the bottom of the snyk security issue).

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch 2 times, most recently from 3eff65d to aa0dce7 Compare February 8, 2023 13:57
skyerus added a commit that referenced this pull request Feb 9, 2023
@skyerus
refactor: isolate flag state management to store (#383)
fef9b87 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- Isolates flag state management to store package

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes #371 

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->
I've ran [flagd's integration
tests](#312) against this
build to ensure behaviour is as before.

---------

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch 2 times, most recently from 51c0d49 to 9b49128 Compare February 10, 2023 15:22
@skyerus
Copy link
Copy Markdown
Contributor Author

skyerus commented Feb 10, 2023

Introduced TLS testing, this is subject to open-feature/go-sdk-contrib#113 being merged and released. Will update the PR once that is done. Moving to draft until then.

@skyerus skyerus marked this pull request as draft February 10, 2023 15:23
@skyerus skyerus mentioned this pull request Feb 10, 2023
Merged
2 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2023 •
edited
Loading

Codecov Report

Merging #312 (41702b4) into main (04014e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files          11       11           
  Lines        1325     1325           
=======================================
  Hits          847      847           
  Misses        428      428           
  Partials       50       50

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 9b49128 to 0867af8 Compare February 10, 2023 16:22
@skyerus
chore: integration tests
76e877a 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
included link to issue
57a0467 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
split load and run flagd image
2fc277c 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
load & run flagd image
6a723c5 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
update docs to use flagd binary directly
d112531 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
bump test-harness
40eda76 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus
tls integration tests
76b37e0 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus force-pushed the issue-176_integration-test-suite branch from 0867af8 to 76b37e0 Compare February 21, 2023 15:45
@skyerus
setup go
41702b4 
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus marked this pull request as ready for review February 21, 2023 16:20
@toddbaert
Copy link
Copy Markdown
Member

toddbaert commented Feb 21, 2023

The security issue is a false positive as confirmed by snyk support.

@toddbaert toddbaert self-requested a review February 21, 2023 16:27
@skyerus skyerus merged commit 6192ac8 into open-feature:main Feb 22, 2023
@skyerus skyerus deleted the issue-176_integration-test-suite branch February 22, 2023 13:22
@github-actions github-actions Bot mentioned this pull request Feb 28, 2023
Merged
beeme1mr pushed a commit that referenced this pull request Mar 2, 2023
@github-actions
chore(main): release 0.4.0 (#412)
408bb7c 
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](v0.3.7...v0.4.0)
(2023-03-02)


### ⚠ BREAKING CHANGES

* Use OTel to export metrics (metric name changes)
([#419](#419))

### 🧹 Chore

* add additional sections to the release notes
([#449](#449))
([798f71a](798f71a))
* attach image sbom to release artefacts
([#407](#407))
([fb4ee50](fb4ee50))
* **deps:** update actions/configure-pages digest to fc89b04
([#417](#417))
([04014e7](04014e7))
* **deps:** update amannn/action-semantic-pull-request digest to b6bca70
([#441](#441))
([ce0ebe1](ce0ebe1))
* **deps:** update docker/login-action digest to ec9cdf0
([#437](#437))
([2650670](2650670))
* **deps:** update docker/metadata-action digest to 3343011
([#438](#438))
([e7ebf32](e7ebf32))
* **deps:** update github/codeql-action digest to 32dc499
([#439](#439))
([f91d91b](f91d91b))
* **deps:** update google-github-actions/release-please-action digest to
d3c71f9 ([#406](#406))
([6e1ffb2](6e1ffb2))
* disable caching tests in CI
([#442](#442))
([28a35f6](28a35f6))
* fix race condition on init read
([#409](#409))
([0c9eb23](0c9eb23))
* integration test stability
([#432](#432))
([5a6a5d5](5a6a5d5))
* integration tests
([#312](#312))
([6192ac8](6192ac8))
* reorder release note sections
([df7bfce](df7bfce))
* use -short flag in benchmark tests
([#431](#431))
([e68a6aa](e68a6aa))


### 🐛 Bug Fixes

* **deps:** update kubernetes packages to v0.26.2
([#450](#450))
([2885227](2885227))
* **deps:** update module github.com/bufbuild/connect-go to v1.5.2
([#416](#416))
([feb7f04](feb7f04))
* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.9
([#427](#427))
([42d2705](42d2705))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.29 ([#429](#429))
([b7fae81](b7fae81))
* **deps:** update module github.com/stretchr/testify to v1.8.2
([#440](#440))
([ab3e674](ab3e674))
* **deps:** update module golang.org/x/net to v0.7.0
([#410](#410))
([c6133b6](c6133b6))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.5
([#454](#454))
([f907f11](f907f11))
* remove non-error error log from parseFractionalEvaluationData
([#446](#446))
([34aca79](34aca79))


### ✨ New Features

* add debug logging for merge behaviour
([#456](#456))
([dc71e84](dc71e84))
* add Health and Readiness probes
([#418](#418))
([7f2358c](7f2358c))
* Add version to startup message
([#430](#430))
([8daf613](8daf613))
* introduce flag merge behaviour
([#414](#414))
([524f65e](524f65e))
* introduce grpc sync for flagd
([#297](#297))
([33413f2](33413f2))
* refactor and improve K8s sync provider
([#443](#443))
([4c03bfc](4c03bfc))
* Use OTel to export metrics (metric name changes)
([#419](#419))
([eb3982a](eb3982a))


### 📚 Documentation

* add .net flagd provider
([73d7840](73d7840))
* configuration merge docs
([#455](#455))
([6cb66b1](6cb66b1))
* documentation for creating a provider
([#413](#413))
([d0c099d](d0c099d))
* updated filepaths for schema store regex
([#344](#344))
([2d0e9d9](2d0e9d9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
raphael-wigoutschnigg-dt pushed a commit to open-feature-forking/flagd that referenced this pull request Mar 11, 2025
@renovate
fix(deps): update module github.com/hashicorp/golang-lru/v2 to v2.0.7 (…
cd2a830 
…open-feature#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toddbaert toddbaert toddbaert approved these changes

@james-milligan james-milligan james-milligan approved these changes

@AlexsJones AlexsJones Awaiting requested review from AlexsJones

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees

@toddbaert toddbaert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create integration test suite

3 participants

@skyerus @toddbaert @james-milligan