chore: move startServer functions into errGroups#566
Merged
beeme1mr merged 6 commits intoopen-feature:mainfrom Mar 31, 2023
Merged
chore: move startServer functions into errGroups#566beeme1mr merged 6 commits intoopen-feature:mainfrom
beeme1mr merged 6 commits intoopen-feature:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 70.81% 70.91% +0.10%
==========================================
Files 21 21
Lines 2162 2187 +25
==========================================
+ Hits 1531 1551 +20
- Misses 574 577 +3
- Partials 57 59 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thisthat
approved these changes
Mar 28, 2023
bacherfl
force-pushed
the
chore/refactor-server-setup
branch
from
4647466 to
d6af957
Compare
Contributor
|
Looks good and this makes things clear. Please fix the lint issue :) hint - |
toddbaert
approved these changes
Mar 28, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
thisthat
force-pushed
the
chore/refactor-server-setup
branch
from
cf3dc3f to
fa6690e
Compare
Kavindu-Dodan
approved these changes
Mar 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #554 to make use of
errGroupsfor starting the server and metrics server of the flag evaluation component, as discussed in #554 (comment)