-
Notifications
You must be signed in to change notification settings - Fork 112
chore: add new flagd-evaluator e2e suite #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
99e0c6a
chore: implement json eval suite
toddbaert 285b2bf
fixup: flags in ci
toddbaert 96b898a
fixup: multi-line cmd
toddbaert 623886e
fixup: latest changes
toddbaert 368a9e3
fixup: use latest commit
toddbaert b49206f
fixup: remove temporary stuff
toddbaert 0f0dc48
Merge branch 'main' into chore/json-eval-tests
toddbaert 2621436
Merge branch 'main' into chore/json-eval-tests
toddbaert b90c3d7
Merge branch 'main' into chore/json-eval-tests
toddbaert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| [submodule "test-harness"] | ||
| path = test-harness | ||
| url = https://github.com/open-feature/test-harness.git | ||
| [submodule "spec"] | ||
|
toddbaert marked this conversation as resolved.
|
||
| path = spec | ||
| url = https://github.com/open-feature/spec.git | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package integration_test | ||
|
|
||
| import ( | ||
| "flag" | ||
| "testing" | ||
|
|
||
| "github.com/cucumber/godog" | ||
| flagd "github.com/open-feature/go-sdk-contrib/providers/flagd/pkg" | ||
|
toddbaert marked this conversation as resolved.
|
||
| "github.com/open-feature/go-sdk-contrib/tests/flagd/pkg/integration" | ||
| ) | ||
|
|
||
| func TestJsonEvaluator(t *testing.T) { | ||
| if testing.Short() { | ||
| t.Skip() | ||
| } | ||
|
|
||
| flag.Parse() | ||
|
|
||
| var providerOptions []flagd.ProviderOption | ||
| name := "flagd-json-evaluator.feature" | ||
|
|
||
| testSuite := godog.TestSuite{ | ||
| Name: name, | ||
| ScenarioInitializer: integration.InitializeFlagdJsonScenario(providerOptions...), | ||
| Options: &godog.Options{ | ||
| Format: "pretty", | ||
| Paths: []string{"../../../test-harness/gherkin/flagd-json-evaluator.feature"}, | ||
| TestingT: t, // Testing instance that will run subtests. | ||
| Strict: true, | ||
| }, | ||
| } | ||
|
|
||
| if testSuite.Run() != 0 { | ||
| t.Fatal("non-zero status returned, failed to run evaluation tests") | ||
| } | ||
| } | ||
Submodule test-harness
updated
from 48c56d to 6493d0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.