Skip to content

docs: Add docs about $flag.properties#965

Merged
toddbaert merged 10 commits intoopen-feature:mainfrom
craigpastro:docs-for-flagd-properties
Oct 14, 2023
Merged

docs: Add docs about $flag.properties#965
toddbaert merged 10 commits intoopen-feature:mainfrom
craigpastro:docs-for-flagd-properties

Conversation

@craigpastro
Copy link
Copy Markdown
Member

@craigpastro craigpastro commented Oct 12, 2023

This PR

I had a go at adding docs for the $flagd properties. In general, I think this is something that I am terrible at, so please let me know if you have any suggestions.

A couple of other things:

  • I renamed JSON Logic to JsonLogic to be consistent in other places
  • I added some missing periods

Related Issues

Closes #962.

Notes

Follow-up Tasks

How to test

Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
@craigpastro craigpastro requested a review from a team October 12, 2023 17:58
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 12, 2023

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 84de508
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/652aa0936269520008b123cd

Comment thread docs/reference/flag-definitions.md
Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
Copy link
Copy Markdown
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments but it looks good to me. Thanks for putting it together.

Comment thread docs/reference/flag-definitions.md Outdated
Comment thread docs/reference/flag-definitions.md Outdated
Comment thread docs/reference/specifications/in-process-providers.md
Comment thread docs/reference/specifications/in-process-providers.md Outdated
Comment thread docs/reference/flag-definitions.md
Comment thread docs/reference/flag-definitions.md Outdated
Comment thread docs/reference/specifications/in-process-providers.md
Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
Comment thread docs/reference/flag-definitions.md Outdated
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Comment thread docs/reference/flag-definitions.md Outdated
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Comment thread docs/reference/specifications/in-process-providers.md Outdated
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Comment thread docs/reference/specifications/in-process-providers.md Outdated
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert merged commit 608535a into open-feature:main Oct 14, 2023
@craigpastro craigpastro deleted the docs-for-flagd-properties branch October 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[doc] ad doc about $flag.properties (flagKey and timestamp)

4 participants