feat: Improve wait logic to a more elegant solution #1160#1169
Merged
toddbaert merged 22 commits intoopen-feature:mainfrom Feb 26, 2025
Merged
Conversation
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
…ant-solution-open-feature#1160 # Conflicts: # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java # providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolverTest.java
…re#1160 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
github-actions
Bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
chrfwow
commented
Jan 21, 2025
aepfli
approved these changes
Jan 21, 2025
Member
aepfli
left a comment
aepfli
left a comment
There was a problem hiding this comment.
thank you - i just added some questions and suggestions, nothing crucial except the one about where we are doing this wait and notify
Contributor
Author
|
|
…open-feature#1160 # Conflicts: # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
aepfli
reviewed
Feb 17, 2025
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
aepfli
approved these changes
Feb 18, 2025
…open-feature#1160 # Conflicts: # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java # providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/EventSteps.java
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
aepfli
approved these changes
Feb 19, 2025
Member
|
I'll be sure to review this tomrrow. |
toddbaert
reviewed
Feb 25, 2025
toddbaert
reviewed
Feb 25, 2025
Member
|
I'll merge this tomorrow unless I hear objections. |
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
…gant-solution-#1160' into improve-wait-logic-to-a-more-elegant-solution-open-feature#1160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds a better wait logic to wait for the initialization of the
FlagdProvider.With these changes, it is not advisable to restart a
FlagdProvideronce it has been shut down.Related Issues
Fixes #1160