feat: ofrep provider#1429
Merged
toddbaert merged 13 commits intoopen-feature:mainfrom Jul 17, 2025
Merged
Conversation
chrfwow
reviewed
Jun 18, 2025
toddbaert
requested review from
aepfli,
beeme1mr,
liran2000,
lukas-reining and
toddbaert
liran2000
reviewed
Jun 19, 2025
Member
liran2000
left a comment
liran2000
left a comment
There was a problem hiding this comment.
thanks for this 😃 added some comments
Rahul-Baradol
force-pushed
the
ofrep-provider
branch
4 times, most recently
from
bae4f4f to
5ea2826
Compare
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Rahul-Baradol
force-pushed
the
ofrep-provider
branch
from
5ea2826 to
c18d670
Compare
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
liran2000
reviewed
Jun 21, 2025
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
liran2000
approved these changes
Jun 22, 2025
Member
liran2000
left a comment
liran2000
left a comment
There was a problem hiding this comment.
I see the review comments were addressed, thanks.
Added some more review comments on last commits, approving, can wait for others to review as well.
aepfli
approved these changes
Jun 23, 2025
Member
aepfli
left a comment
aepfli
left a comment
There was a problem hiding this comment.
Thank you this looks good to me. I am just questioning if we should maybe more often use the @Value lombok annotation to generate record like objects. I think this could reduce some of the boilderplate even more here. Thank you
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Member
Author
|
How can we proceed here? |
chrfwow
approved these changes
Jun 30, 2025
Member
|
from my perspective this is good to go, but I would love to have somebody from the OFREP sig also as part of the reviewers @thomaspoignant @lukas-reining (or maybe somebody else) |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
reviewed
Jul 16, 2025
| */ | ||
| public OfrepApi(Duration requestTimeout, Duration connectTimeout, ProxySelector proxySelector, Executor executor) { | ||
| httpClient = HttpClient.newBuilder() | ||
| .connectTimeout(connectTimeout) |
Member
There was a problem hiding this comment.
We could possibly add keepAlive settings, but by default I think there's a 30s pooled connection so I think that's good for now.
toddbaert
reviewed
Jul 16, 2025
toddbaert
reviewed
Jul 16, 2025
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
reviewed
Jul 16, 2025
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
approved these changes
Jul 16, 2025
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
@Rahul-Baradol I made a few very small changes:
- used a
ParseErrorinstead of aGeneralErrorwhere I thought it made sense - updated the parent pom dependency requiring latest SDK version
- added myself to the owners
If that's all OK with you, don't do anything! I will merge tomorrow. If not, please say so!
This was referenced Jul 17, 2025
Member
Author
|
Ohh no issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1413
Follow-up Tasks