feat: use namespaced schemas for flagd json schemas (#843)#850
Merged
toddbaert merged 1 commit intoopen-feature:mainfrom Jun 28, 2024
Merged
feat: use namespaced schemas for flagd json schemas (#843)#850toddbaert merged 1 commit intoopen-feature:mainfrom
toddbaert merged 1 commit intoopen-feature:mainfrom
Conversation
Signed-off-by: Sanket Mehta <mehtasankets@gmail.com>
github-actions
Bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
Kavindu-Dodan
approved these changes
Jun 28, 2024
Collaborator
Kavindu-Dodan
left a comment
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Change looks good. Validated locally and it works 🙌
toddbaert
approved these changes
Jun 28, 2024
Member
|
Thanks @mehtasankets ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: use namespaced schemas for flagd json schemas
Use namespaced schemas for flags and targeting json schemas
Related Issues
Fixes #843
Notes
src/main/resources/flagd/schemas/instead ofsrc/main/resources/src/main/resources/flagd/schemas/