feat: kube-flagd-proxy deployment by james-milligan · Pull Request #412 · open-feature/open-feature-operator

james-milligan · 2023-03-22T15:58:49Z

This PR

adds new provider type kube-proxy

  sources:
  - source: default/example
    provider: kube-proxy

Use the kube-proxy provider + create a deployment with the normal deployment path, the operator will deploy Kubernetes proxy, denying pod deployment until it is ready to receive requests

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

Signed-off-by: James Milligan <james@omnant.co.uk>

Kavindu-Dodan · 2023-03-23T18:17:35Z

Cool work. I like the approach you took with provider: kube-proxy option.

Look forward to the refined PR

Signed-off-by: James Milligan <james@omnant.co.uk>

codecov · 2023-03-24T16:41:06Z

Codecov Report

Merging #412 (eb7b15c) into main (5ba5bc9) will decrease coverage by 6.50%.
The diff coverage is 51.76%.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   84.26%   77.76%   -6.50%     
==========================================
  Files          19       21       +2     
  Lines        1061     1300     +239     
==========================================
+ Hits          894     1011     +117     
- Misses        138      248     +110     
- Partials       29       41      +12

Impacted Files	Coverage Δ
...pis/core/v1alpha1/flagsourceconfiguration_types.go	`98.76% <0.00%> (-1.24%)`	⬇️
pkg/utils/utils.go	`38.09% <0.00%> (-61.91%)`	⬇️
webhooks/pod_webhook.go	`78.23% <5.26%> (-11.00%)`	⬇️
...rollers/core/flagsourceconfiguration/controller.go	`46.37% <57.14%> (+1.21%)`	⬆️
webhooks/error_types.go	`57.14% <57.14%> (ø)`
...s/core/flagsourceconfiguration/kube-flagd-proxy.go	`77.41% <77.41%> (ø)`
webhooks/pod_webhook_deprecated.go	`47.61% <100.00%> (ø)`

Flag	Coverage Δ
component-tests	`75.83% <12.30%> (-9.04%)`	⬇️
unit-tests	`61.69% <48.62%> (-2.78%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: James Milligan <james@omnant.co.uk>

…proxy-deployment

Signed-off-by: James Milligan <james@omnant.co.uk>

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>

Signed-off-by: James Milligan <james@omnant.co.uk>

…igan/open-feature-operator into kube-proxy-deployment

Signed-off-by: James Milligan <james@omnant.co.uk>

thisthat

LGTM ✅

## This PR  - renames package `kube-flagd-proxy` to `flagd-proxy` - updates all references of `kube-flagd-proxy` to `flagd-proxy` ### Related Issues  open-feature/open-feature-operator#412 (comment) ### Notes  ### Follow-up Tasks   ### How to test  --------- Signed-off-by: James Milligan <james@omnant.co.uk>

Signed-off-by: James Milligan <james@omnant.co.uk>

kube-proxy deployment

1121d00

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan changed the title ~~POC: flagd-kube-proxy deployment~~ feat: POC flagd-kube-proxy deployment Mar 22, 2023

introduce error type for silent deferral

0be2ba4

Signed-off-by: James Milligan <james@omnant.co.uk>

beeme1mr reviewed Mar 23, 2023

View reviewed changes

Comment thread apis/core/v1alpha1/flagsourceconfiguration_types.go Outdated

beeme1mr reviewed Mar 23, 2023

View reviewed changes

Comment thread config/rbac/kustomization.yaml Outdated

beeme1mr reviewed Mar 23, 2023

View reviewed changes

Comment thread webhooks/pod_webhook.go

Kavindu-Dodan reviewed Mar 23, 2023

View reviewed changes

Comment thread webhooks/pod_webhook.go Outdated

Kavindu-Dodan reviewed Mar 23, 2023

View reviewed changes

Comment thread webhooks/pod_webhook.go Outdated

initial configuration options for kube proxy

b125c9a

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan commented Mar 24, 2023

View reviewed changes

Comment thread chart/open-feature-operator/values.yaml Outdated

remove comment

c9d5bb0

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan commented Mar 24, 2023

View reviewed changes

Comment thread webhooks/pod_webhook.go Outdated

james-milligan added 2 commits March 24, 2023 16:09

move kube proxy deployment to reconcile loop of fsconfig

21fbeb8

Signed-off-by: James Milligan <james@omnant.co.uk>

merge conflicts

f96637b

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan added 6 commits March 27, 2023 11:44

proxy deployment timeout error

2013ea6

Signed-off-by: James Milligan <james@omnant.co.uk>

basic unit tests

3aa96ff

Signed-off-by: James Milligan <james@omnant.co.uk>

merge conflicts

b4dc16c

Signed-off-by: James Milligan <james@omnant.co.uk>

test refactor

bada658

Signed-off-by: James Milligan <james@omnant.co.uk>

docs

179b0be

Signed-off-by: James Milligan <james@omnant.co.uk>

import fix

a790efd

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan changed the title ~~feat: POC flagd-kube-proxy deployment~~ feat: flagd-kube-proxy deployment Mar 28, 2023

james-milligan marked this pull request as ready for review March 28, 2023 12:03

james-milligan requested a review from a team March 28, 2023 12:03

james-milligan added 5 commits March 28, 2023 13:27

linting fixes

38b9d4d

Signed-off-by: James Milligan <james@omnant.co.uk>

Merge http://github.com/open-feature/open-feature-operator into kube-…

61fd4d1

…proxy-deployment

renovate config

026d04b

Signed-off-by: James Milligan <james@omnant.co.uk>

renovate marker

877e790

Signed-off-by: James Milligan <james@omnant.co.uk>

chart readme

fe3c4bf

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan added 8 commits March 29, 2023 10:04

cleanup

45bbaa8

Signed-off-by: James Milligan <james@omnant.co.uk>

table format

9704c52

Signed-off-by: James Milligan <james@omnant.co.uk>

docs

648ada3

Signed-off-by: James Milligan <james@omnant.co.uk>

file name fix

c73cca6

Signed-off-by: James Milligan <james@omnant.co.uk>

file name fix

bc98c50

Signed-off-by: James Milligan <james@omnant.co.uk>

SA fix

db9b326

Signed-off-by: James Milligan <james@omnant.co.uk>

docs

29f9906

Signed-off-by: James Milligan <james@omnant.co.uk>

tightened permissions

678d98e

Signed-off-by: James Milligan <james@omnant.co.uk>

james-milligan changed the title ~~feat: flagd-kube-proxy deployment~~ feat: kube-flagd-proxy deployment Mar 29, 2023

isolate kube proxy handler

e658051

Signed-off-by: James Milligan <james@omnant.co.uk>

Kavindu-Dodan approved these changes Mar 29, 2023

View reviewed changes

thisthat reviewed Mar 30, 2023

View reviewed changes

Comment thread chart/open-feature-operator/README.md Outdated

Comment thread controllers/core/flagsourceconfiguration/kube-flagd-proxy.go Outdated

Comment thread controllers/core/flagsourceconfiguration/kube-flagd-proxy.go Outdated

james-milligan and others added 3 commits March 30, 2023 09:48

Update chart/open-feature-operator/README.md

d43a9af

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>

error handling improvement in test

e285382

Signed-off-by: James Milligan <james@omnant.co.uk>

Merge branch 'kube-proxy-deployment' of https://github.com/james-mill…

1bcda73

…igan/open-feature-operator into kube-proxy-deployment

james-milligan mentioned this pull request Mar 30, 2023

feat!: rename kube-flagd-proxy to flagd-proxy open-feature/flagd#576

Merged

james-milligan added 2 commits March 30, 2023 11:30

env var utils + configuration decoupling

9e35b2c

Signed-off-by: James Milligan <james@omnant.co.uk>

additional labels

5eee5a6

Signed-off-by: James Milligan <james@omnant.co.uk>

thisthat approved these changes Mar 30, 2023

View reviewed changes

james-milligan added 5 commits March 31, 2023 10:28

refactor

b9928a9

Signed-off-by: James Milligan <james@omnant.co.uk>

bug fix + refactor

22a64e0

Signed-off-by: James Milligan <james@omnant.co.uk>

merge

ed2f128

Signed-off-by: James Milligan <james@omnant.co.uk>

tag fix

ed929f7

Signed-off-by: James Milligan <james@omnant.co.uk>

version fix

eb7b15c

Signed-off-by: James Milligan <james@omnant.co.uk>

toddbaert self-requested a review March 31, 2023 16:12

toddbaert approved these changes Mar 31, 2023

View reviewed changes

james-milligan merged commit 651c63c into open-feature:main Mar 31, 2023

github-actions Bot mentioned this pull request Mar 31, 2023

chore(main): release 0.2.32 #407

Merged

toddbaert mentioned this pull request Apr 3, 2023

Support kube-flagd-proxy deployment in OFO #377

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: kube-flagd-proxy deployment#412

feat: kube-flagd-proxy deployment#412
james-milligan merged 39 commits intoopen-feature:mainfrom
james-milligan:kube-proxy-deployment

james-milligan commented Mar 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kavindu-Dodan commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 24, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thisthat left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

james-milligan commented Mar 22, 2023

This PR

Related Issues

Notes

Follow-up Tasks

How to test

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kavindu-Dodan commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thisthat left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Mar 24, 2023 •

edited

Loading