Skip to content

[BUG][flagd-inprocess] Semver detection is not recognizing versions prefixed with an "v" like "v1.0.0" #106

@aepfli

Description

@aepfli

use https://github.com/open-feature/python-sdk-contrib/pull/105/files#diff-c0e0afcf1c3a48af5dba2265c040eb008205f50860791d77316b748205907d2aR87-R144 to verify this. this is the migrated test code from the js flagd provider

see documentation for python semver https://python-semver.readthedocs.io/en/3.0.0-dev.3/usage.html#creating-subclasses-from-version

our code were it fails:

try:
v1 = semver.Version.parse(str(arg1))
v2 = semver.Version.parse(str(arg2))
except ValueError as e:
logger.exception(e)
return None

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions