chore: add conformance tests, SimpleCov, version standardization, and README improvements#95
Conversation
… README improvements - Add conformance shared examples to flagd, flagsmith, flipt, go-feature-flag, meta_provider - Add SimpleCov to all providers (flagd, flipt, meta_provider, ofrep, flagsmith, go-feature-flag) - Standardize version constants to VERSION (go-feature-flag, meta_provider, ofrep) - Improve Flipt, Meta Provider, and OFREP provider READMEs with full documentation - Auto-correct pre-existing rubocop offenses in flagsmith and meta_provider Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jose Colella <jose.colella@gusto.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the maturity and maintainability of the OpenFeature Ruby SDK providers. It focuses on improving code quality through standardized testing, comprehensive code coverage, consistent versioning practices, and detailed documentation. These changes aim to make the providers more robust, easier to understand, and more compliant with OpenFeature specifications, ultimately benefiting developers by providing a more reliable and well-documented toolkit. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements across multiple providers, including adding conformance tests, integrating SimpleCov for test coverage, standardizing version constants, and significantly enhancing the README files. The code changes are well-executed, with notable improvements like more specific error handling in the meta provider. My review focuses on a potential issue in the documentation regarding the required Ruby version, which appears to be a typo across several files.
|
|
||
| ## Requirements | ||
|
|
||
| - Ruby >= 3.4 |
|
|
||
| ## Requirements | ||
|
|
||
| - Ruby >= 3.4 |
There was a problem hiding this comment.
|
|
||
| ## Requirements | ||
|
|
||
| - Ruby >= 3.4 |
- Remove conformance shared examples from flagd (method_missing delegation pattern prevents parameter introspection) - Add .rubocop.yml to meta_provider inheriting from shared config - Re-run rubocop auto-correct with correct shared config (double quotes) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jose Colella <jose.colella@gusto.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.11](openfeature-go-feature-flag-provider/v0.1.10...openfeature-go-feature-flag-provider/v0.1.11) (2026-03-09) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.0.6](openfeature-meta_provider/v0.0.5...openfeature-meta_provider/v0.0.6) (2026-03-09) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) * update minimum Ruby version to >= 3.4 ([#83](#83)) ([ccf689a](ccf689a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Jose Colella <jose.colella@gusto.com> Co-authored-by: Jose Colella <jose.colella@gusto.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merge origin/main into pr/ofrep-provider. Resolved conflicts by accepting main's versions which include improvements from PR #95 (conformance tests, SimpleCov, version standardization, README improvements). The ofrep-provider entry is preserved in both manifest and release-please config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jose Colella <jose.colella@gusto.com>
🤖 I have created a release *beep* *boop* --- ## [0.0.3](openfeature-flipt-provider/v0.0.2...openfeature-flipt-provider/v0.0.3) (2026-03-09) ### ✨ New Features * add OFREP provider ([#80](#80)) ([e33e0ab](e33e0ab)) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) * update minimum Ruby version to >= 3.4 ([#83](#83)) ([ccf689a](ccf689a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.1](openfeature-ofrep-provider-v0.1.0...openfeature-ofrep-provider/v0.1.1) (2026-03-09) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Jose Colella <jose.colella@gusto.com> Co-authored-by: Jose Colella <jose.colella@gusto.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.5](openfeature-flagd-provider/v0.1.4...openfeature-flagd-provider/v0.1.5) (2026-03-09) ### ✨ New Features * add OFREP provider ([#80](#80)) ([e33e0ab](e33e0ab)) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Jose Miguel Colella <josecolella@yahoo.com> Co-authored-by: Jose Miguel Colella <josecolella@yahoo.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.2](openfeature-flagsmith-provider/v0.1.1...openfeature-flagsmith-provider/v0.1.2) (2026-03-09) ### ✨ New Features * add OFREP provider ([#80](#80)) ([e33e0ab](e33e0ab)) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) * update minimum Ruby version to >= 3.4 ([#83](#83)) ([ccf689a](ccf689a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Jose Miguel Colella <josecolella@yahoo.com> Co-authored-by: Jose Miguel Colella <josecolella@yahoo.com>
🤖 I have created a release *beep* *boop* --- ## [0.1.1](openfeature-meta_provider-v0.1.0...openfeature-meta_provider/v0.1.1) (2026-03-18) ### 🐛 Bug Fixes * don't init if provider doesn't have an init method ([#49](#49)) ([d2479ed](d2479ed)) ### ✨ New Features * add matched provider to flag metadata in MetaProvider ([#31](#31)) ([d48b182](d48b182)) * add OFREP provider ([#80](#80)) ([e33e0ab](e33e0ab)) * **meta_provider:** add multi-provider evaluation strategies ([#102](#102)) ([9cce3f4](9cce3f4)) ### 🧹 Chore * add conformance tests, SimpleCov, version standardization, and README improvements ([#95](#95)) ([1c430a9](1c430a9)) * **deps:** update dependency ruby to v3.4.9 ([#107](#107)) ([e0d4314](e0d4314)) * improve repository maturity and contributor experience ([#91](#91)) ([7e28025](7e28025)) * **main:** release openfeature-meta_provider 0.0.2 ([#32](#32)) ([6b63b49](6b63b49)) * **main:** release openfeature-meta_provider 0.0.3 ([#35](#35)) ([ca82b95](ca82b95)) * **main:** release openfeature-meta_provider 0.0.4 ([#48](#48)) ([456d35e](456d35e)) * **main:** release openfeature-meta_provider 0.0.5 ([#50](#50)) ([4015ba2](4015ba2)) * **main:** release openfeature-meta_provider 0.0.6 ([#88](#88)) ([f21b22f](f21b22f)) * **main:** release openfeature-meta_provider 0.0.7 ([#97](#97)) ([71a7c48](71a7c48)) * update minimum Ruby version to >= 3.4 ([#83](#83)) ([ccf689a](ccf689a)) * update readme title ([#34](#34)) ([06f1517](06f1517)) ### 🛠️ Build * **meta-provider:** Support non-breaking versions of openfeature-sdk ([#47](#47)) ([5a98cf4](5a98cf4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Summary
Continuation of #91 — implements the remaining recommendations from the repository maturity analysis.
it_behaves_like "an OpenFeature provider"shared examples to flagd, flagsmith, flipt, go-feature-flag, and meta_provider specs (OFREP already had them)SimpleCov.startGO_FEATURE_FLAG_PROVIDER_VERSION,META_PROVIDER_VERSION, andOFREP_PROVIDER_VERSIONtoVERSIONnested in their respective modules (Ruby convention)Test plan
🤖 Jose's AI agent