Skip to content

feat!: add Ruby 4.0 support, require minimum Ruby 3.4 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josecolella merged 4 commits into from
Mar 5, 2026
Merged

feat!: add Ruby 4.0 support, require minimum Ruby 3.4 #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
117144b
feat!: add Ruby 4.0 support, require minimum Ruby 3.4
josecolella Mar 5, 2026
9cf7a89
style: use short ruby version for linter CI job
josecolella Mar 5, 2026
8e57584
fix: upgrade simplecov-cobertura to v3 for Ruby 4.0 compatibility
josecolella Mar 5, 2026
965e413
style: fix EmptyLinesAfterModuleInclusion lint offenses
josecolella Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ jobs:
# - macos-latest
# - windows-latest
ruby:
- "3.3"
- "3.2"
- "3.1"
- "4.0"
- "3.4"
env:
BUNDLE_GEMFILE: Gemfile

Expand All @@ -46,7 +45,7 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.4.8
ruby-version: "3.4"
- run: bundle install
- name: Standard
run: bundle exec rake standard
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.4.8
4.0.1
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby 3.4.8
ruby 4.0.1
99 changes: 57 additions & 42 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,46 @@ PATH
GEM
remote: https://rubygems.org/
specs:
ast (2.4.2)
debug (1.9.2)
ast (2.4.3)
date (3.5.1)
debug (1.11.1)
irb (~> 1.10)
reline (>= 0.3.8)
diff-lcs (1.5.1)
docile (1.4.0)
io-console (0.7.2)
irb (1.12.0)
rdoc
diff-lcs (1.6.2)
docile (1.4.1)
erb (6.0.2)
io-console (0.8.2)
irb (1.17.0)
pp (>= 0.6.0)
prism (>= 1.3.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.7.1)
language_server-protocol (3.17.0.3)
json (2.18.1)
language_server-protocol (3.17.0.5)
lint_roller (1.1.0)
markly (0.10.0)
parallel (1.24.0)
parser (3.3.0.5)
markly (0.15.2)
parallel (1.27.0)
parser (3.3.10.2)
ast (~> 2.4.1)
racc
psych (5.1.2)
pp (0.6.3)
prettyprint
prettyprint (0.2.0)
prism (1.9.0)
psych (5.3.1)
date
stringio
racc (1.7.3)
racc (1.8.1)
rainbow (3.1.1)
rake (13.1.0)
rdoc (6.6.3.1)
rake (13.3.1)
rdoc (7.2.0)
erb
psych (>= 4.0.0)
regexp_parser (2.9.0)
reline (0.5.0)
tsort
regexp_parser (2.11.3)
reline (0.6.3)
io-console (~> 0.5)
rexml (3.3.6)
strscan
rexml (3.4.4)
rspec (3.12.0)
rspec-core (~> 3.12.0)
rspec-expectations (~> 3.12.0)
Expand All @@ -49,54 +59,59 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-support (3.12.2)
rubocop (1.62.1)
rubocop (1.84.2)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.49.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.2)
parser (>= 3.3.0.4)
rubocop-performance (1.20.2)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.30.0, < 2.0)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.49.0)
parser (>= 3.3.7.2)
prism (~> 1.7)
rubocop-performance (1.26.1)
lint_roller (~> 1.1)
rubocop (>= 1.75.0, < 2.0)
rubocop-ast (>= 1.47.1, < 2.0)
ruby-progressbar (1.13.0)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov_json_formatter (~> 0.1)
simplecov-cobertura (2.1.0)
simplecov-cobertura (3.1.0)
rexml
simplecov (~> 0.19)
simplecov-html (0.12.3)
simplecov-html (0.13.2)
simplecov_json_formatter (0.1.4)
standard (1.35.1)
standard (1.54.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.62.0)
rubocop (~> 1.84.0)
standard-custom (~> 1.0.0)
standard-performance (~> 1.3)
standard-performance (~> 1.8)
standard-custom (1.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.50)
standard-performance (1.3.1)
standard-performance (1.9.0)
lint_roller (~> 1.1)
rubocop-performance (~> 1.20.2)
stringio (3.1.0)
strscan (3.1.0)
rubocop-performance (~> 1.26.0)
stringio (3.2.0)
timecop (0.9.10)
unicode-display_width (2.5.0)
tsort (0.2.0)
unicode-display_width (3.2.0)
unicode-emoji (~> 4.1)
unicode-emoji (4.2.0)

PLATFORMS
arm64-darwin-21
arm64-darwin-22
arm64-darwin-23
arm64-darwin-24
arm64-darwin-25
x64-mingw-ucrt
x64-mingw32
x86_64-darwin-19
Expand All @@ -111,7 +126,7 @@ DEPENDENCIES
rake (~> 13.0)
rspec (~> 3.12.0)
simplecov (~> 0.22.0)
simplecov-cobertura (~> 2.1.0)
simplecov-cobertura (~> 3.0)
standard
standard-performance
timecop (~> 0.9.10)
Expand Down
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@

| Supported Ruby Version | OS |
| ------------ | --------------------- |
| Ruby 3.1.4 | Windows, MacOS, Linux |
| Ruby 3.2.3 | Windows, MacOS, Linux |
| Ruby 3.3.0 | Windows, MacOS, Linux |
| Ruby 3.4.x | Windows, MacOS, Linux |
| Ruby 4.0.x | Windows, MacOS, Linux |

### Install

Expand Down
4 changes: 2 additions & 2 deletions openfeature-sdk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
spec.description = "Ruby SDK for an the specifications for the open standard of feature flag management"
spec.homepage = "https://github.com/open-feature/openfeature-ruby"
spec.license = "Apache-2.0"
spec.required_ruby_version = ">= 3.1"
spec.required_ruby_version = ">= 3.4"

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = "https://github.com/open-feature/openfeature-ruby"
Expand All @@ -38,6 +38,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "standard"
spec.add_development_dependency "standard-performance"
spec.add_development_dependency "simplecov", "~> 0.22.0"
spec.add_development_dependency "simplecov-cobertura", "~> 2.1.0"
spec.add_development_dependency "simplecov-cobertura", "~> 3.0"
spec.add_development_dependency "timecop", "~> 0.9.10"
end
1 change: 1 addition & 0 deletions spec/open_feature/sdk/hooks/hook_executor_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ def before(hook_context:, hints:)

hook2_class = Class.new do
include OpenFeature::SDK::Hooks::Hook

define_method(:initialize) { |log| @log = log }

define_method(:before) do |hook_context:, hints:|
Expand Down
1 change: 1 addition & 0 deletions spec/support/recording_hook_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module RecordingHookHelper
def recording_hook(name, call_log)
Class.new do
include OpenFeature::SDK::Hooks::Hook

define_method(:hook_name) { name }

define_method(:before) do |hook_context:, hints:|
Expand Down
Loading