Merged
Conversation
josecolella
changed the title
josecolella
force-pushed
the
jc-add-api-object
branch
2 times, most recently
from
a7d73e8 to
7cc6102
Compare
josecolella
force-pushed
the
jc-add-api-object
branch
2 times, most recently
from
e2d7a44 to
61d0606
Compare
mschoenlaub
reviewed
Nov 14, 2022
Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
- Remove Error class from SDK Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
Signed-off-by: Jose Colella <jose.colella@gusto.com>
josecolella
force-pushed
the
jc-add-api-object
branch
from
5cec0b2 to
a62ebf8
Compare
toddbaert
approved these changes
Nov 14, 2022
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks for keeping it digestible.
Collaborator
Author
|
Team going to merge this, but please let me know if there are any follow ups. I will continue to provide easy to review PR instead of everything in one PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
References #7
Notes
Follow-up Tasks
How to test
bundle exec rspec