Update French Principles and Glossary files #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Member
|
thanks so much! would you please fix the DCO sign-off? The DCO bot check gives step by step instructions. Ping me if i can help with that. |
Closed
Signed-off-by: Julia Furst Morgado <juliafmorgado@gmail.com>
Signed-off-by: Julia Furst Morgado <juliafmorgado@gmail.com>
Member
|
Thanks for fixing DCO - and for noticing this repo's CONTRIBUTING guidelines doens't mention that as a requirement! Our GitHub org's default contributing file does, but the repo-specific one overrides that, so we need to fix that. I opened an issue to track that: Anyway, we now just need another French speaker to review this PR 😄 |
Implement lrochette's recommendations Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
scottrigby
approved these changes
Aug 14, 2024
Member
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
Great work @juliafmorgado and @lrochette 🤝 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julia Furst Morgado juliafmorgado@gmail.com
Related to #77