Make yagp_hooks_collector compile and run#14
Merged
NJrslv merged 10 commits intoyagp-hooks-collectorfrom Jan 19, 2026
Merged
Conversation
Copy of open-gpdb/gpdb@8813a55 from gpdb to collect workfile stats in yagp-hooks-collector.
Copy of open-gpdb/gpdb@476b540 from gpdb to create a global QueryState for unique hashing for yagp-hooks-collector.
Update usage in yagp_hooks_collector of - heap_create_with_catalog() - standard_ExecutorRun() - standard_ProcessUtility() - InstrAlloc() - CreateTemplateTupleDesc() - ExplainInitState() -> NewExplainState() - gpmon_gettmid() -> gp_gettmid() - Gp_session_role -> Gp_role - strerror(errno) -> "%m" - Include utils/varlena.h for SplitIdentifierString() in gpdbwrappers.cpp.
Remove unnecessary copies of the core jumbling functions from yagp_hooks_collector/stat_statements_parser. In commit [1] query jumbling moved to core, thus there is no need to keep a copy of jumbling functions in yagp_hooks_collector. [1] 5fd9dfa
In yagp_hooks_collector we need control over place where function is executed, and Cloudberry supports only set-returning functions to execute on COORDINATOR so change the type of the functions. We can see the error below without this change: ERROR: EXECUTE ON COORDINATOR is only supported for set-returning functions.
In gpdb create table was executed for each partition. Now one single create table is executed. Thus only one create table query goes through executor. Change the test accordingly.
Change makefile, test and add it to CI of yagp_hooks_collector. Similarly to open-gpdb/gpdb@7be8893.
Author
|
Test have passed here https://github.com/open-gpdb/cloudberry/actions/runs/21131348233. |
Smyatkin-Maxim
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimal changes to make yagp_hooks_collector from open-gpdb/yagp_hooks_collector running on cloudberry.
DO NOT SQUASH/REBASE THIS BRANCH. I want to preserve commits and merge this branch directly into
yagp_hooks_collector, then, eventually, mergeyagp_hooks_collectordirectly intomain.Please see the commits with their messages, for the reference, they are listed below: