Fix error when locale is misconfigured in yagp-hooks-collector#19
Merged
NJrslv merged 1 commit intoyagp-hooks-collectorfrom Jan 21, 2026
Merged
Conversation
The extension generates normalized query text and plan using jumbling functions. Those functions may fail when translating to wide character if the current locale cannot handle the character set. Fix changed functions that generate normalized query text/plan to noexcept versions so we can check if error occured and continute execution. The test checks that even when those functions fail, the plan is still executed. This test is partially taken from src/test/regress/gp_locale.sql.
Author
|
The CI check is here: https://github.com/open-gpdb/cloudberry/actions/runs/21210673626 |
NJrslv
added a commit
that referenced
this pull request
Jan 23, 2026
* ereport(log) bug queries at the end of extension
leborchuk
pushed a commit
that referenced
this pull request
Mar 18, 2026
* ereport(log) bug queries at the end of extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension generates normalized query text and plan using jumbling functions. Those functions may fail when translating to wide character if the current locale cannot handle the character set.
Fix changes functions that generate normalized query text/plan to noexcept versions so we can check if error occured and continute execution.
The test checks that even when those functions fail, the plan is still executed. This test is partially taken from src/test/regress/gp_locale.sql.
Without this check we would terminate backend with this message:
FATAL: Unexpected exception in yagpcc zero-length delimited identifier at or near """"