Closed
Conversation
fc3705a to
c857b13
Compare
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 94.53% 94.49% -0.04%
==========================================
Files 179 182 +3
Lines 7702 7888 +186
==========================================
+ Hits 7281 7454 +173
- Misses 421 434 +13
|
c4850ee to
0dfced0
Compare
alolita
approved these changes
Dec 8, 2020
alolita
left a comment
There was a problem hiding this comment.
Lgtm mostly. Pl add inline comments esp for functions
e.g. in exporters/ostream/src/log_exporter.cc
ranton256
reviewed
Dec 8, 2020
303810c to
542be20
Compare
added 8 commits
December 8, 2020 17:53
5b69bd1 to
644a625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements an exporter to Ostream for the logging pipeline, as part of Issue # 337.
This PR adds:
unique_ptrto ashared_ptrwhen passed from Logger SDK --> processor --> exporter, as proposed as a solution in # 412. This change applies to many test files, processor interfaces and implementations, and across the exporter interface and implementations.OStreamLogExportertakes the batch ofLogRecords from the processor, and sends each field to an OStream. The default configuration is to send the data tostd::cout.cout,cerr, andclog, and an integration test for the full logging pipeline fromLogger API --> LoggerSDK --> Simple Log Processor --> OStream Log ExporterNote that all changes in
log_record.h,logger.h, andnoop.hin this PR can be ignored, as they are covered by # 422. However, including them here allows them to pass the CI and for this PR to be merged without # 422.cc @MarkSeufert @alolita