Use std=gnu89, the gcc 4.8 default #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
While modifying code to be more like the changes suggested in #9 may be a good thing, for P8 at least the least invasive thing to do is to just specify the language standard. |
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 3, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
ghost
mentioned this pull request
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 3, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 3, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 3, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 4, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
According to https://gcc.gnu.org/gcc-5/porting_to.html GCC 5 changed to defaulting to -std=gnu11 rather than -std=gnu89, which causes build failures with OCC code use of 'extern inline'. so, to work around this, and to stay on a more predictable path, explicitly set the standard to gnu89. Change-Id: I87b8e2f62aad55f0ff4c34eca7752b5ee2f0db28 Fixes: open-power#8 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
ghost
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 6, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Author
|
Now up to date with open-power/op-build#721 and the comments from @williamspatrick there (notably the inclusion of a change-id). I don't seem to have access to the internal OCC repository, so this pull request exists here. |
ghost
pushed a commit
to stewartsmith/op-build
that referenced
this pull request
Nov 7, 2016
We bring in P8 Hostboot patches from open-power/hostboot#62 as we wait for Hostboot development team to merge them. OCC patch is from open-power/occ#15 . It simply sets the language to gnu89 with -std=gnu89, which is the default prior to GCC5 (see https://gcc.gnu.org/gcc-5/porting_to.html ) Fixes: open-power/occ#8 Fixes: open-power/hostboot#69 Fixes: open-power/hostboot#61 Fixes: open-power#355 Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Member
|
Fixed in 7254446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://gcc.gnu.org/gcc-5/porting_to.html GCC 5
changed to defaulting to -std=gnu11 rather than -std=gnu89, which
causes build failures with OCC code use of 'extern inline'.
so, to work around this, and to stay on a more predictable path,
explicitly set the standard to gnu89.
Fixes: #8
Signed-off-by: Stewart Smith stewart@linux.vnet.ibm.com
This change is