Add errno details to journal traces #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced error logging by including errno values in journal traces when file operations like open() fail. This provides more detailed diagnostics for debugging I/O issues. Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>
| free(path); | ||
| if (!cfam_id_file) { | ||
| pdbg_log(PDBG_ERROR, "Unable to open CFAM ID file\n"); | ||
| pdbg_log(PDBG_ERROR, "Unable to open CFAM ID file errno: %d\n",errno); |
There was a problem hiding this comment.
After free() errno may have changed. It might be better to check before free() or save the errno.
| } | ||
|
|
||
| PR_INFO("Unable to open %s\n", path); | ||
| PR_INFO("Unable to open %s, errno: %d \n", path, errno); |
There was a problem hiding this comment.
It is far away from open failure and error prone. Always better to have it close to failure or save the errno.
| rc = sbefifo_connect(sbefifo_path, proc, &sf->sf_ctx); | ||
| if (rc) { | ||
| PR_ERROR("Unable to open sbefifo driver %s\n", sbefifo_path); | ||
| PR_ERROR("Unable to open sbefifo driver %s errno: %d\n", sbefifo_path, rc); |
There was a problem hiding this comment.
Do you want to print rc here as we don't know when errno was set in the sbefifo_connect(), right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced error logging by including errno values in journal traces when file operations like open() fail. This provides more detailed diagnostics for debugging I/O issues.