forked from google/dart_cli_script
-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Problem
Several subprocess environment tests fail on Windows:
- includes modifications to env
- includes scoped modifications to env
- includes values from the environment parameter
- environment parameter overrides env
- includeParentEnvironment: false ignores env
- includeParentEnvironment: false uses environment parameter
Reproduction
- Run: https://github.com/open-runtime/dart_cli_script/actions/runs/22376939954
- windows-x64 job: https://github.com/open-runtime/dart_cli_script/actions/runs/22376939954/job/64769258023
- windows-arm64 job: https://github.com/open-runtime/dart_cli_script/actions/runs/22376939954/job/64769258042
Observed failure modes
- Case-sensitive key assertions fail (
cli_script_test_*vs uppercase env keys on Windows). includeParentEnvironment: falsepath can fail with Windows process/environment semantics.
Expected behavior
- Env assertions should work with Windows case-insensitive key semantics.
includeParentEnvironment: falseshould behave predictably on Windows and not fail process start due to invalid/minimal env block behavior.
Proposed approach
- Make env-related test assertions case-insensitive on Windows.
- Revisit env construction when
includeParentEnvironment: falseandenvironmentis null/empty. - Add dedicated Windows tests for:
- explicit env override behavior
- includeParentEnvironment=false with/without explicit env
Acceptance criteria
- All six env-related failures pass on
windows-x64andwindows-arm64 - No regressions on Linux/macOS env tests
- Documented Windows-specific environment semantics where behavior is intentionally different
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working