-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
Description
Summary
Comprehensive audit found 8 silent mutations and 6 missing-BEFORE-state operations across the CLI commands.
Critical Silent Mutations (no logging at all)
| Location | Operation |
|---|---|
create_release_command.dart:238-265 |
git config + git add (verbose-only) |
manage_cicd.dart:2019-2039 |
git config + git add (verbose-only) |
act.dart:101-105 |
Game plan JSON writes |
consumers_command.dart:1214-1224 |
_atomicWriteJson |
step_summary.dart:12 |
GitHub Step Summary appends |
template_manifest.dart:96 |
Template version tracker save |
version_detection.dart:148,163 |
Gemini response JSON writes |
sub_package_utils.dart:278,369 |
Sub-package pubspec mutations |
Missing BEFORE State
| Location | Operation |
|---|---|
create_release_command.dart:117 |
pubspec version bump (no old→new) |
update_command.dart:219-256 |
Template file copies (no diff) |
audit_command.dart:126 |
pubspec fixes (no before state) |
compose_command.dart:116 |
CHANGELOG write |
autodoc_command.dart:59-62 |
Legacy migration |
init_command.dart:242-249 |
.gitignore append |
Pattern to Follow
Every mutation should:
- Before: Log intent + current state
- Execute: Do the thing
- After: Log success/failure + what changed
Fix Plan
- Add logging wrappers for git operations in release commands
- Add before/after logging for
act.dartgame plan writes - Log old→new version in pubspec bumps
- Log file diffs or summaries for template updates
- Ensure
_atomicWriteJsonlogs its operations - Add logging for all
writeAsStringSynccalls in release pipeline
Reactions are currently unavailable