-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
P2-mediumMedium priorityMedium priorityarea/ci-cdCI/CD workflow generationCI/CD workflow generationenhancementNew feature or requestNew feature or requestneeds-investigationstatus/needs-triagetriaged
Description
Context
After the PR #29 hardening and follow-up fixes (6e04666), most review findings are addressed. A few broader, cross-command trust-boundary risks remain and should be handled as a dedicated pass.
This issue tracks those remaining items so they are implemented intentionally instead of piecemeal.
Remaining hardening scope
-
Constrain
update-all --scan-roottrust boundaryupdate_all_command.dartcurrently accepts arbitraryscanRoot.- Add policy and enforcement (e.g. require within cwd/repo unless explicit override flag).
-
Reduce shell-string execution surface (
sh -c)- Audit
CiProcessRunner.runSync(command)call sites and other shell string interpolation paths. - Migrate to argument-array process APIs where practical.
- For unavoidable shell strings, require centralized escaping helper and tests.
- Audit
-
Validate repository slug inputs consistently
- For
--repo/GITHUB_REPOSITORY-derived values used in git URLs, tags, and links. - Enforce canonical
owner/repoformat before use.
- For
-
Constrain writable/readable path inputs in prompt + artifact helpers
- Validate path arguments (e.g., prompt/artifact file paths) resolve inside expected repo/runtime dirs.
-
Add regression tests for these trust boundaries
- Negative tests for rejected paths/slugs.
- Positive tests for valid inputs.
- Ensure behavior is explicit and documented.
Definition of done
-
scanRootboundary policy implemented and tested. - Shell-string execution surface audited and reduced.
- Repo slug validation implemented at all relevant entry points.
- Path-boundary checks added for file-path inputs.
- Tests added for each new guardrail.
- Documentation updated where user-facing behavior changes.
Notes
- Related follow-up issues: Stream NDJSON parsing to reduce memory pressure for large test suites #30, Add rendered YAML golden file test to catch template/output drift #31, Expand TestCommand test coverage: timeout, failure, and sub-package paths #32.
- This issue is intentionally broader than those task-specific items.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2-mediumMedium priorityMedium priorityarea/ci-cdCI/CD workflow generationCI/CD workflow generationenhancementNew feature or requestNew feature or requestneeds-investigationstatus/needs-triagetriaged