-
Notifications
You must be signed in to change notification settings - Fork 0
feat: multi-package support for CLI commands #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f8de5d3
feat: add multi-package support for analyze, test, autodoc, changelog…
tsavo-at-pieces 8628da3
fix(triage): add --repo to all gh commands + org allowlist to prevent…
tsavo-at-pieces 01f4e77
fix: address review findings — org guard, autodoc dedup, git diff fal…
tsavo-at-pieces 5998b73
feat: add multi-platform CI matrix generation
tsavo-at-pieces 8523871
fix: remove || true debug leftover + redundant path normalization
tsavo-at-pieces 5f641ae
fix(ci): avoid queued self-hosted x64 runners
tsavo-at-pieces File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While path normalization removes trailing slashes from config paths, the concatenation
'$repoRoot/$path'on line 57 could still produce unexpected results if the path contains leading slashes or is an absolute path. Consider adding validation to ensure paths are relative and don't start with/or contain..segments, which could escape the repository root.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable — paths come from a trusted developer-maintained config file.
The
pathvalue is read from.runtime_ci/config.json, which is checked into the repo by the developer who runsci init. This is not untrusted user input — it's a configuration file under version control, equivalent to entries inpubspec.yamloranalysis_options.yaml. Adding path traversal guards here would be security theater against a threat model that doesn't apply (a developer who controls the config file already has full access to the repo).This matches the existing pattern in the codebase —
RepoUtils.findRepoRoot(),WorkflowGenerator.loadCiConfig(), etc. all concatenate paths from config without validation.