Feat 4466 deepgram language detection using node #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat:4466 add deepgram language detection
Author
|
@stnguyen90 can you give it a look? |
stnguyen90
requested changes
Jun 2, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out.
|
|
||
| module.exports = async (req, res) => { | ||
| const { fileUrl } = JSON.parse(req.payload); | ||
| const {apiKey} = JSON.parse(req.variables["DEEPGRAM_API_KEY"]); |
Contributor
There was a problem hiding this comment.
You shouldn't need to parse the variable like this 🧐
| res.json({ | ||
| success: false, | ||
| message: "API key is required.", | ||
| }); |
Contributor
There was a problem hiding this comment.
make sure to return after this so execution doesn't continue
| res.json({ | ||
| success: false, | ||
| message: "File Url is required.", | ||
| }); |
Contributor
There was a problem hiding this comment.
make sure to return after this so execution doesn't continue
Contributor
|
@Player256, will you be able to address the comments I left? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes appwrite/appwrite#4466
