refactor: extract maintenance #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
force-pushed
the
refactor-extract-maintenance
branch
6 times, most recently
from
14d72aa to
8854e94
Compare
loks0n
force-pushed
the
refactor-extract-maintenance
branch
from
8854e94 to
3ddd696
Compare
loks0n
commented
Dec 30, 2025
| // Silently try to kill container | ||
| try { | ||
| $this->orchestration->remove($runtimeName, true); | ||
| } catch (Throwable $th) { |
Member
Author
There was a problem hiding this comment.
Small fix, these were overwriting $th var
ChiragAgg5k
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executor has a 'maintenance' task that removes inactive runtimes on an interval:
executor/src/Executor/Runner/Docker.php
Line 117 in 9f15a25
If we switch to coroutines, this will be started many times, we need to remove the code from the initialisation of Docker class and put it in the server startup hook to ensure it's started once per container.