Feat: v3 support #22
Merged
Feat: v3 support #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->param('runtimeId', '', new Text(64), 'The runtimeID to execute.') | ||
| ->param('payload', '', new Text(8192), 'Data to be forwarded to the function, this is user specified.', true) | ||
| ->param('variables', [], new Assoc(), 'Environment variables passed into runtime.', true) | ||
| ->param('body', '', new Text(20971520), 'Data to be forwarded to the function, this is user specified.', true) |
Contributor
There was a problem hiding this comment.
on what basis is this limit set? what if the payload exceeds this size? For example when uploading a file in chunks ? Can we make sure it accepts 5MB ?
Contributor
Author
There was a problem hiding this comment.
This should support up to 20MB, which is limit that we consider reasonable even in Appwrite.
5MB chunk uploads should work just fine. Trying to upload 30MB file at once will fail.
stnguyen90
reviewed
Feb 25, 2023
| ], | ||
| [ | ||
| 'image' => 'openruntimes/node:v2-18.0', | ||
| 'image' => 'openruntimes/node:v3-18.0', |
Contributor
There was a problem hiding this comment.
Now that we have both v3 and v2 images, does the warm up task in the beginning also pull the v3 images?
Contributor
Author
There was a problem hiding this comment.
Only v3 images. v2 are no longer pulled.
christyjacob4
requested changes
Feb 27, 2023
Contributor
christyjacob4
left a comment
christyjacob4
left a comment
There was a problem hiding this comment.
Looks good. Please address the comments
christyjacob4
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for communication with both
v2andv3of Open Runtime.