Skip to content

allowBom -> skipBom #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dota17 merged 1 commit into from
Apr 28, 2020
Merged

allowBom -> skipBom #1162

dota17 merged 1 commit into from
Apr 28, 2020

Conversation

@dota17
Copy link
Member

@dota17 dota17 commented Apr 28, 2020

Modify condition and the optional name.

@coveralls
Copy link

coveralls commented Apr 28, 2020

Coverage Status

Coverage remained the same at 93.881% when pulling 383fa5d on dota17:skip-Bom into 83946a2 on open-source-parsers:master.

@dota17
Copy link
Member Author

dota17 commented Apr 28, 2020

The original name allowBom is confusing, so I changed it.

@dota17 dota17 merged commit 2cb16b3 into open-source-parsers:master Apr 28, 2020
@dota17 dota17 deleted the skip-Bom branch May 7, 2020 06:42
@axic axic mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dota17 @coveralls