Skip to content

Comments

Temp#75

Merged
calvinyeungck merged 2 commits intomasterfrom
temp
Feb 17, 2026
Merged

Temp#75
calvinyeungck merged 2 commits intomasterfrom
temp

Conversation

@calvinyeungck
Copy link
Member

This pull request introduces improvements to the handling and processing of "bepro" soccer event data, particularly by ensuring that the match_id is consistently included throughout the data loading and processing pipeline. It also updates test cases and output formats to reflect the inclusion of match_id, and bumps the package version.

Bepro data handling and processing improvements:

  • Updated the load_bepro function in soccer_load_data.py to require and propagate a match_id parameter, ensuring that the match identifier is consistently available during data processing. [1] [2]
  • Modified the internal get_additional_features function to add a match_id column to the event DataFrame, and ensured this is called with the correct argument throughout the pipeline. [1] [2]
  • Updated the UIED_bepro function in soccer_processing.py to include match_id as the first column in the output DataFrame, improving traceability of processed data.

Testing and sample data updates:

  • Revised the process_single_match function to add a new test case for "bepro" data, including the use of the match_id parameter, and commented out the previous "soccertrack" test case.

Miscellaneous and maintenance:

  • Bumped the package version in pyproject.toml from 0.1.51 to 0.1.53 to reflect these changes.
  • Minor code cleanup in UIED_bepro, removing an unnecessary increment operation.
  • Added a missing import for Union from typing in soccer_load_data.py.

Calvin Yeung added 2 commits February 17, 2026 16:05
@calvinyeungck calvinyeungck merged commit 254bcd8 into master Feb 17, 2026
3 checks passed
@github-actions
Copy link

Init Test Results 📝

  • Status: success
  • OS: Linux
  • Python: 3.10

@github-actions
Copy link

Init Test Results 📝

  • Status: success
  • OS: Linux
  • Python: 3.8

@github-actions
Copy link

Init Test Results 📝

  • Status: success
  • OS: Linux
  • Python: 3.9

@calvinyeungck calvinyeungck deleted the temp branch February 17, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant