Move old metrics implementation to different directory, and rename targets to *_deprecated#1053
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 151 151
Lines 5971 5971
=======================================
Hits 5663 5663
Misses 308 308 |
reyang
approved these changes
Nov 4, 2021
ThomsonTan
reviewed
Nov 4, 2021
ThomsonTan
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As the effort required to update our existing metrics SDK implementation as per new specs is huge, it's easier to re-write it from the ground-up ( #1033 ). This means we could
We discussed both approaches in the community meeting and agreed on second. This PR makes necessary changes for it, basically
*/_metrics/*directory, and new development continue under*/metrics/*.opentelemetry_metrics_deprecated,prometheus_exporter_deprecatedps. - We can also use this PR on discussing both approaches if required. The first approach does provide cleaner repo and easy maintainability.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes