Otlp http cmake build fail#1133
Merged
ThomsonTan merged 3 commits intoDec 13, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 165 165
Lines 6229 6229
=======================================
Hits 5817 5817
Misses 412 412 |
lalitb
approved these changes
Dec 13, 2021
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Just curious why build didn't fail in our CI env.
Member
Author
probably because of including |
ThomsonTan
reviewed
Dec 13, 2021
| #include "google/protobuf/stubs/common.h" | ||
|
|
||
| #if defined(GOOGLE_PROTOBUF_VERSION) && GOOGLE_PROTOBUF_VERSION >= 3007000 | ||
| # include "google/protobuf/stubs/stringpiece.h" |
Contributor
There was a problem hiding this comment.
Wondering why it is necessary to include stringpiece.h because Base64Escape is declared in strutil.h?
Contributor
CI is not failing probably because we are using a newer version of protobuf. The explicit declaration is only old protobuf versions. |
ThomsonTan
approved these changes
Dec 13, 2021
This was referenced Jan 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1132 (issue)
Changes
Please provide a brief description of the changes here.
Use proper overload.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes