Skip to content

InMemorySpanExporter shutdown#1161

Merged
lalitb merged 2 commits into
open-telemetry:mainfrom
esigo:InMemorySpanExporter-shutdown
Dec 23, 2021
Merged

InMemorySpanExporter shutdown#1161
lalitb merged 2 commits into
open-telemetry:mainfrom
esigo:InMemorySpanExporter-shutdown

Conversation

@esigo
Copy link
Copy Markdown
Member

@esigo esigo commented Dec 22, 2021

Fixes InMemorySpanExporter shutdown

Changes

The ::export() stops exporting when the exporter was shutdown.
For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team December 22, 2021 13:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2021

Codecov Report

Merging #1161 (33c35bd) into main (1cf2422) will decrease coverage by 0.02%.
The diff coverage is 66.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   93.39%   93.38%   -0.01%     
==========================================
  Files         165      165              
  Lines        6230     6233       +3     
==========================================
+ Hits         5818     5820       +2     
- Misses        412      413       +1     
Impacted Files Coverage Δ
...lemetry/exporters/memory/in_memory_span_exporter.h 94.45% <66.67%> (-5.55%) ⬇️

@lalitb lalitb merged commit bb9d5de into open-telemetry:main Dec 23, 2021
@esigo esigo deleted the InMemorySpanExporter-shutdown branch December 23, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants