[WIP] multi-platform scheduled builds#1165
Closed
esigo wants to merge 5 commits intoopen-telemetry:mainfrom
Closed
[WIP] multi-platform scheduled builds#1165esigo wants to merge 5 commits intoopen-telemetry:mainfrom
esigo wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 91.55% 91.37% -0.17%
==========================================
Files 217 221 +4
Lines 7922 8247 +325
==========================================
+ Hits 7252 7535 +283
- Misses 670 712 +42
|
Member
|
Should we build our development docker image instead install and build dependencies every time?It may reduce a lot time to all CI jobs. |
Member
Author
Thanks, yeah I totally agree. The question is where to host. We discussed this in one of the meetings and there is no plan to host docker images. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides multi-platform scheduled builds, so we can test build on different CPU architectures e.g. arm64 or OS versions.
example build command (building with gcc 8.5):
docker build --build-arg BASE_IMAGE=gcc:8.5 -f ../docker/ubuntuLatest/Dockerfile . -t otel-cppChanges
uses
setup_grpc.shandsetup_thrift.shscripts inDockerfilein multiple stages so that Docker can build the stages in parallel.The ARM build can take up to 3 hours because of the emulation.
If the image built with the scheduled job, pushed to some registry, it can be directly used on ARM machines as well.
As the build using this method is very slow, a
cronjob is used.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes