Skip to content

[Not For Review] Metrics Aggregation SDK#1173

Closed
lalitb wants to merge 5 commits into
open-telemetry:mainfrom
lalitb:aggregator-sdk
Closed

[Not For Review] Metrics Aggregation SDK#1173
lalitb wants to merge 5 commits into
open-telemetry:mainfrom
lalitb:aggregator-sdk

Conversation

@lalitb
Copy link
Copy Markdown
Member

@lalitb lalitb commented Jan 14, 2022

not to be reviewed Splitting this draft PR into smaller PRs for ease of review.
Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team January 14, 2022 09:09
@lalitb lalitb marked this pull request as draft January 14, 2022 09:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2022

Codecov Report

Merging #1173 (62ad88e) into main (1f0bf83) will decrease coverage by 2.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   93.29%   90.70%   -2.59%     
==========================================
  Files         174      185      +11     
  Lines        6391     6587     +196     
==========================================
+ Hits         5962     5974      +12     
- Misses        429      613     +184     
Impacted Files Coverage Δ
api/include/opentelemetry/common/timestamp.h 90.00% <0.00%> (-10.00%) ⬇️
...pentelemetry/sdk/metrics/aggregator/accumulation.h 0.00% <0.00%> (ø)
...telemetry/sdk/metrics/aggregator/drop_aggregator.h 0.00% <0.00%> (ø)
...etry/sdk/metrics/aggregator/histogram_aggregator.h 0.00% <0.00%> (ø)
...etry/sdk/metrics/aggregator/lastvalue_aggregator.h 0.00% <0.00%> (ø)
...ntelemetry/sdk/metrics/aggregator/sum_aggregator.h 0.00% <0.00%> (ø)
...nclude/opentelemetry/sdk/metrics/data/point_data.h 0.00% <0.00%> (ø)
...clude/opentelemetry/sdk/metrics/view/aggregation.h 100.00% <ø> (+66.67%) ⬆️
sdk/include/opentelemetry/sdk/metrics/view/view.h 63.64% <ø> (ø)
sdk/src/metrics/meter.cc 13.64% <0.00%> (-0.64%) ⬇️
... and 23 more

@lalitb lalitb changed the title [WIP] Metrics Aggregation SDK [Not For Review] Metrics Aggregation SDK Jan 21, 2022
@github-actions github-actions Bot added the Stale label Mar 22, 2022
@lalitb
Copy link
Copy Markdown
Member Author

lalitb commented Mar 23, 2022

Not required anymore.

1 similar comment
@lalitb
Copy link
Copy Markdown
Member Author

lalitb commented Mar 23, 2022

Not required anymore.

@lalitb lalitb closed this Mar 23, 2022
@lalitb lalitb closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant