Skip to content

Sync and Async Instruments SDK#1184

Merged
lalitb merged 16 commits into
open-telemetry:mainfrom
lalitb:instruments-sdk
Feb 10, 2022
Merged

Sync and Async Instruments SDK#1184
lalitb merged 16 commits into
open-telemetry:mainfrom
lalitb:instruments-sdk

Conversation

@lalitb
Copy link
Copy Markdown
Member

@lalitb lalitb commented Jan 28, 2022

Changes

This PR adds below classes for metrics SDK:

  • synch instruments implementation
  • async instruments implementation
  • Measurement Processor - This is analogous to Span Processor for traces, and all the measurements flow through this.
  • Metric Storage - To store the metrics for the readers. These would call the aggregation API ( Add Aggregation as part of metrics SDK. #1178) to do the actual aggregation, to generate metrics data.

Some of these classes are placeholders and would be enriched once more flow gets added.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team January 28, 2022 05:56
@lalitb lalitb changed the title Instruments sdk Sync and Async Instruments SDK Jan 28, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2022

Codecov Report

Merging #1184 (aeab6cf) into main (e1c8557) will decrease coverage by 0.10%.
The diff coverage is 79.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   93.44%   93.35%   -0.09%     
==========================================
  Files         185      193       +8     
  Lines        6720     6908     +188     
==========================================
+ Hits         6279     6448     +169     
- Misses        441      460      +19     
Impacted Files Coverage Δ
...i/include/opentelemetry/metrics/sync_instruments.h 100.00% <ø> (ø)
...nclude/opentelemetry/sdk/metrics/metric_exporter.h 100.00% <ø> (ø)
sdk/src/metrics/meter_context.cc 38.10% <0.00%> (-1.90%) ⬇️
sdk/test/metrics/meter_provider_sdk_test.cc 80.56% <0.00%> (ø)
sdk/src/metrics/meter.cc 18.19% <11.77%> (+3.90%) ⬆️
.../opentelemetry/sdk/metrics/measurement_processor.h 42.11% <42.11%> (ø)
sdk/src/metrics/meter_provider.cc 74.29% <50.00%> (-4.50%) ⬇️
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 54.55% <54.55%> (ø)
sdk/test/metrics/async_instruments_test.cc 69.24% <69.24%> (ø)
...lude/opentelemetry/sdk/metrics/async_instruments.h 100.00% <100.00%> (ø)
... and 5 more

Comment thread sdk/include/opentelemetry/sdk/metrics/state/sync_metric_storage.h Outdated
Comment thread sdk/include/opentelemetry/sdk/metrics/instruments.h Outdated
Comment thread sdk/include/opentelemetry/sdk/metrics/meter.h Outdated
Comment thread sdk/include/opentelemetry/sdk/metrics/async_instruments.h
Comment thread sdk/include/opentelemetry/sdk/metrics/measurement_processor.h
Comment thread sdk/include/opentelemetry/sdk/metrics/metric_reader.h Outdated
Comment thread sdk/src/metrics/meter.cc Outdated
Comment thread sdk/test/metrics/async_instruments_test.cc Outdated
@lalitb lalitb mentioned this pull request Feb 8, 2022
3 tasks
Copy link
Copy Markdown
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

@lalitb lalitb merged commit 04e3a68 into open-telemetry:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants